-
Notifications
You must be signed in to change notification settings - Fork 62.2k
Refactor export GPG_TTY command to add line break (#25721) #25722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The command to add `GPG_TTY` does not update the shell config correctly if the file ends in a comment. I previously installed pnpm so running the command changed my `.zshrc` file to: ``` #pnpm endexport GPG_TTY=$(tty) ``` Fixed by updating each instance of the command to: ``` echo -e '\nexport GPG_TTY=\$(tty)' ```
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@AlmostEfficient Thank you for opening a PR and linking it to your issue! ✨ We appreciate the extra context, too. I'll get this triaged for review! ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement! We'll get this merged down for you.
.../authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md
Outdated
Show resolved
Hide resolved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
The command to add
GPG_TTY
does not update the shell config correctly if the file ends in a comment.I previously installed pnpm so running this changed my
.zshrc
file to:Why:
Closes: #25721
What's being changed (if available, include any code snippets, screenshots, or gifs):
Fixed by updating each instance of the command from:
to:
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.