Skip to content

Refactor export GPG_TTY command to add line break (#25721) #25722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

AlmostEfficient
Copy link
Contributor

@AlmostEfficient AlmostEfficient commented May 27, 2023

The command to add GPG_TTY does not update the shell config correctly if the file ends in a comment.

$ if [ -r ~/.zshrc ]; then echo 'export GPG_TTY=$(tty)' >> ~/.zshrc; \
  else echo 'export GPG_TTY=$(tty)' >> ~/.zprofile; fi

I previously installed pnpm so running this changed my .zshrc file to:

#pnpm endexport GPG_TTY=$(tty)

Why:

Closes: #25721

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fixed by updating each instance of the command from:

echo 'export GPG_TTY=$(tty)'

to:

echo -e '\nexport GPG_TTY=\$(tty)'

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

The command to add `GPG_TTY` does not update the shell config correctly if the file ends in a comment.

I previously installed pnpm so running the command changed my  `.zshrc` file to:
```
#pnpm endexport GPG_TTY=$(tty)
```

Fixed by updating each instance of the command to:
```
echo -e '\nexport GPG_TTY=\$(tty)'
```
@welcome
Copy link

welcome bot commented May 27, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 27, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/managing-commit-signature-verification/telling-git-about-your-signing-key.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@AlmostEfficient Thank you for opening a PR and linking it to your issue! ✨

We appreciate the extra context, too. I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added automerge content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review using git Content related to using git and removed triage Do not begin working on this issue until triaged by the team labels May 30, 2023
skedwards88
skedwards88 previously approved these changes Jun 2, 2023
Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement! We'll get this merged down for you.

@skedwards88 skedwards88 added the ready to merge This pull request is ready to merge label Jun 2, 2023
@skedwards88 skedwards88 enabled auto-merge June 2, 2023 18:29
@skedwards88 skedwards88 added this pull request to the merge queue Jun 2, 2023
Merged via the queue into github:main with commit 200cff5 Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge using git Content related to using git waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shell command to add env var breaks if file ends in a comment
3 participants