Use correct syntax for adding label in dockerfile #2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per official documentation (already linked) https://docs.docker.com/engine/reference/builder/#label
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
SMAKSS
approved these changes
Jan 6, 2021
clarkbw
approved these changes
Jan 6, 2021
Contributor
clarkbw
left a comment
clarkbw
left a comment
There was a problem hiding this comment.
Yep, this is accurate. = is required. Thanks for the fix!
janiceilene
added
content
Contributor
|
Thanks so much for opening a PR for this fix @hardbyte! I'll update the branch and get this merged once tests are passing 🍏 |
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Docker labels are specified in Dockerfiles with an equals sign as per official documentation (already linked in the docs).
The currently documented method for linking GitHub repositories to GHCR packages isn't valid.
Ref #2587
What's being changed:
Check off the following: