Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue self-hosted action-runners docs (#28487) #28488

Merged

Conversation

chickenandpork
Copy link
Contributor

@chickenandpork chickenandpork commented Sep 25, 2023

Why:

Promotes minimum OS requirements to ensure visibility and replace value that can be misleading

Closes: #28487

What's being changed (if available, include any code snippets, screenshots, or gifs):

Action-Runners 2.309.0 continued the shift to newer nodes versions; in this case, node20. Documentation still says that the action-runner supports macOS-11.13 or later, but node20 only supports macOS-11.0 and later, introducing inaccuracy in GH docs.

See also https://github.com/nodejs/node/blob/main/BUILDING.md#platform-list, notably nodejs/node@4e39830 introduced in nodejs/node#49164

This one-liner elevates that new constraint.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Sep 25, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners/about-self-hosted-runners.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@chickenandpork Thanks for opening an issue and submitting a PR! I edited your post slightly to link it to your issue 👍

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 26, 2023
Copy link
Contributor

@jc-clark jc-clark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this @chickenandpork!

I'll help get this merged 🚀

@jc-clark jc-clark added this pull request to the merge queue Sep 26, 2023
Merged via the queue into github:main with commit e43039f Sep 26, 2023
40 of 41 checks passed
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-Hosted Runners compatibility change isn't updated to documentation
3 participants