Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore correct section range in TOS #29415

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Restore correct section range in TOS #29415

merged 4 commits into from
Nov 17, 2023

Conversation

ltm
Copy link
Contributor

@ltm ltm commented Oct 25, 2023 •
edited
Loading

Why:

The reference to "Sections D.4 — D.7" was inadvertently changed to "Sections D.4 — D.1" in 1dfa5c2.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Restores the correct "Sections D.4 — D.7" range.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@ltm
Restore correct section range in TOS
18b1d46 
The reference to "Sections D.4 — D.7" was inadvertently changed to "Sections D.4 — D.1" in 1dfa5c2.
@ltm ltm requested a review from a team as a code owner October 25, 2023 16:31
@welcome
Copy link

welcome bot commented Oct 25, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
site-policy/github-terms/github-terms-of-service.md fpt
 fpt

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@ltm Thanks so much for submitting a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team site policy Content related to site policy waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 25, 2023
mchammer01
mchammer01 approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ltm - thanks for noticing this, and fixing the issue ✨

@mchammer01 mchammer01 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 26, 2023
@mchammer01
Copy link
Contributor

@github/site-policy-admins 👋🏻 - we need your approval before I can merge this PR. Can you take a look? Thanks 🙇🏻

@mchammer01
Copy link
Contributor

@github/site-policy-admins - a gentle bump on my request above 💜

@yueyuecompany23 yueyuecompany23 mentioned this pull request Oct 27, 2023
Closed
1 task
@mchammer01
Copy link
Contributor

@github/site-policy-admins - we need an approval from you before we can merge this PR. Can you help? 🙏🏻 🙇🏻

@mchammer01 mchammer01 added this pull request to the merge queue Nov 17, 2023
Merged via the queue into github:main with commit e2860a2 Nov 17, 2023
41 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

jnewell7 added a commit to jnewell7/docs that referenced this pull request Dec 31, 2023
@jnewell7
Revert "Restore correct section range in TOS (github#29415)"
4dbec8a 
This reverts commit e2860a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margaret-tucker margaret-tucker margaret-tucker approved these changes

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! site policy Content related to site policy waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ltm @cmwilson21 @mchammer01 @margaret-tucker