Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gh issue comment instead of peter-evans/create-or-update-comment #29420

Merged
merged 10 commits into from
Oct 27, 2023
Merged

use gh issue comment instead of peter-evans/create-or-update-comment #29420

merged 10 commits into from
Oct 27, 2023

Conversation

jcbhmr
Copy link
Contributor

@jcbhmr jcbhmr commented Oct 25, 2023

Why:

Closes: #29419

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@welcome
Copy link

welcome bot commented Oct 25, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

cmwilson21 commented Oct 26, 2023

@jcbhmr Thank you for opening a PR and linking it to your issue! ✨

I'll get this triaged for review! ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 26, 2023
peterbe
peterbe previously approved these changes Oct 26, 2023
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a Docs content reviewer but I endorse the idea of switching the third-party action to instead using the gh CLI.

I left some nits for the reviewer.

@jcbhmr
Copy link
Contributor Author

jcbhmr commented Oct 26, 2023

i forgot to mention that this pr also happens to fix this bug:

if: github.event.label.name == 'help-wanted'

👆 doesn't work since the label name is "help wanted" not "help-wanted" and so it never triggers 😢

if: github.event.label.name == 'help wanted'

👆 this works ✅
its whatever name appears here:
image

so this one has "waiting for review" right now but NOT "waiting-for-review". you can check this in the search by clicking on it and seeing whats in the search box/query:
image

"waiting for review" NOT "waiting-for-review"

idk if there are other spots like this in other parts of the documentation too 🤷‍♀️

@smoothzebra

This comment was marked as off-topic.

Copy link
Contributor

@skedwards88 skedwards88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I love this change. I left a few minor comments that I'll go ahead an incorporate, then we'll get this merged for you.

skedwards88
skedwards88 previously approved these changes Oct 27, 2023
@skedwards88 skedwards88 added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge pumpkin-spice Specifically tracked Hacktoberfest issue - internal purposes labels Oct 27, 2023
@skedwards88 skedwards88 added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
@Yme4u

This comment was marked as spam.

@jcbhmr
Copy link
Contributor Author

jcbhmr commented Oct 27, 2023

turns out the workflow does need the --repo flag lol 🤣

image
image

vs with the --repo flag

image
image

i think its down to that gh needs a .git folder (current git repo context) to figure out which remote github repo it corresponds to. if there isn't one then i think you're always required to specify it manually via -R/--repo. 🤷‍♂️

@skedwards88 skedwards88 added this pull request to the merge queue Oct 27, 2023
Merged via the queue into github:main with commit 879f112 Oct 27, 2023
44 checks passed
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jcbhmr jcbhmr deleted the patch-1 branch October 27, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! pumpkin-spice Specifically tracked Hacktoberfest issue - internal purposes ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use GitHub CLI in 'Commenting on an issue when a label is added' page instead of 3rd party action
6 participants