-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use gh issue comment
instead of peter-evans/create-or-update-comment
#29420
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@jcbhmr Thank you for opening a PR and linking it to your issue! ✨ I'll get this triaged for review! ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a Docs content reviewer but I endorse the idea of switching the third-party action to instead using the gh
CLI.
I left some nits for the reviewer.
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Outdated
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Outdated
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Outdated
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Outdated
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Outdated
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Outdated
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Show resolved
Hide resolved
...nt/actions/managing-issues-and-pull-requests/commenting-on-an-issue-when-a-label-is-added.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! I love this change. I left a few minor comments that I'll go ahead an incorporate, then we'll get this merged for you.
This comment was marked as spam.
This comment was marked as spam.
turns out the workflow does need the vs with the i think its down to that |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Closes: #29419
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.