Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add info on what should occur post-transfer #29464

Conversation

CBID2
Copy link
Contributor

@CBID2 CBID2 commented Oct 26, 2023

Why:

@derisen is trying to transfer the ownership of several OAuth apps to an another organization. However, the app's current organization admins are unsure where they can approve the request.

Closes:
Closes #22565

What's being changed (if available, include any code snippets, screenshots, or gifs):

This pull request provides information on what occurs once they give OAuth apps to another person. See screenshot below for reference.

extra steps

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Note to Reviewers

I'm unsure if I should add the information as two steps or place them in a subsection titled "What Should The New Owner Expect". Suggestions are welcomed! :)

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
apps/oauth-apps/maintaining-oauth-apps/transferring-ownership-of-an-oauth-app.md fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae
fpt
ghec
ghes@ 3.10 3.9 3.8 3.7 3.6
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@yueyuecompany23 yueyuecompany23 mentioned this pull request Oct 27, 2023
1 task
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review github apps Content related to GitHub Apps and removed triage Do not begin working on this issue until triaged by the team labels Oct 27, 2023
@cmwilson21
Copy link
Contributor

👋 @CBID2 Thanks for submitting another PR to the docs! 🎉

I'll get this triaged for review! ⚡

Copy link
Contributor

@jhosman jhosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening this PR @CBID2 ⚡ ✨

I'm unsure if I should add the information as two steps or place them in a subsection titled "What Should The New Owner Expect". Suggestions are welcomed! :)

Great question. Since it could be a different person who transfers the app vs completing the transfer, I think it makes sense to leave the info about the final completion actions outside of the procedural list. (So it's more noticeable if someone comes looking for that info.)

We could put it in a subsection as you mentioned, although it would be a very short subsection 😄 So I'm thinking to keep it simple and just place it as a new paragraph below the existing procedural steps.

I'll go ahead and make that change, and we'll get this merged as soon as tests are passing.

Thanks for your help improving GitHub's documentation!

@jhosman jhosman added this pull request to the merge queue Oct 28, 2023
@jhosman jhosman added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Oct 28, 2023
Merged via the queue into github:main with commit 9cb3cc3 Oct 28, 2023
50 checks passed
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@cmwilson21 cmwilson21 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 31, 2023
@CBID2 CBID2 deleted the adding-pointers-to-how-&-where-transfer-requests-can-be-approved branch February 28, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team github apps Content related to GitHub Apps hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transferring ownership article(s) should contain pointers to how/where transfer request can be approved
3 participants