-
Notifications
You must be signed in to change notification settings - Fork 59.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add info on what should occur post-transfer #29464
feat: add info on what should occur post-transfer #29464
Conversation
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
…ests-can-be-approved
👋 @CBID2 Thanks for submitting another PR to the docs! 🎉 I'll get this triaged for review! ⚡ |
…ests-can-be-approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for opening this PR @CBID2 ⚡ ✨
I'm unsure if I should add the information as two steps or place them in a subsection titled "What Should The New Owner Expect". Suggestions are welcomed! :)
Great question. Since it could be a different person who transfers the app vs completing the transfer, I think it makes sense to leave the info about the final completion actions outside of the procedural list. (So it's more noticeable if someone comes looking for that info.)
We could put it in a subsection as you mentioned, although it would be a very short subsection 😄 So I'm thinking to keep it simple and just place it as a new paragraph below the existing procedural steps.
I'll go ahead and make that change, and we'll get this merged as soon as tests are passing.
Thanks for your help improving GitHub's documentation!
content/apps/oauth-apps/maintaining-oauth-apps/transferring-ownership-of-an-oauth-app.md
Outdated
Show resolved
Hide resolved
…nership-of-an-oauth-app.md
…ests-can-be-approved
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
@derisen is trying to transfer the ownership of several OAuth apps to an another organization. However, the app's current organization admins are unsure where they can approve the request.
Closes:
Closes #22565
What's being changed (if available, include any code snippets, screenshots, or gifs):
This pull request provides information on what occurs once they give OAuth apps to another person. See screenshot below for reference.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.
data
directory.For content changes, I have completed the self-review checklist.
Note to Reviewers
I'm unsure if I should add the information as two steps or place them in a subsection titled "What Should The New Owner Expect". Suggestions are welcomed! :)