Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw tags to code blocks #305

Merged
merged 4 commits into from
Oct 9, 2020
Merged

Conversation

lucascosti
Copy link
Contributor

@lucascosti lucascosti commented Oct 9, 2020

Fixes: #287

Why:

Code blocks with context/expression syntax were included without escaping them in {% raw %} tags. This meant that the liquid processing stripped out those mentions.

What's being changed:

Added {% raw %} tags to the affected clode blocks.

Stage preview: https://docs-305--lucascosticomplex-wo.herokuapp.com/en/free-pro-team@latest/actions/learn-github-actions/managing-complex-workflows

Check off the following:

@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @lucascosti 🎸

@lucascosti lucascosti merged commit 7db4a3c into main Oct 9, 2020
@lucascosti lucascosti deleted the lucascosti/complex-workflows-raw_287 branch October 9, 2020 02:12
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
Co-authored-by: Jacob Prall <prall.jacob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secrets example syntax is being stripped out of documentation page "Managing Complex Workflows"
2 participants