Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct for windows slashes in redirect precompile #312

Closed
wants to merge 3 commits into from

Conversation

jeffmcaffer
Copy link
Contributor

Why:

resolves: #311

What's being changed:

see issue

Check off the following:

@jeffmcaffer jeffmcaffer requested a review from chiedo October 9, 2020 02:21
@jeffmcaffer jeffmcaffer requested a review from a team as a code owner October 9, 2020 02:21
@janiceilene janiceilene added engineering Will involve Docs Engineering windows labels Oct 9, 2020
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼 Thanks!

@chiedo chiedo mentioned this pull request Oct 9, 2020
4 tasks
@@ -1,4 +1,5 @@
const path = require('path')

This comment was marked as spam.

@@ -1,4 +1,5 @@
const path = require('path')
const slash = require('slash')

This comment was marked as spam.

@github github locked as spam and limited conversation to collaborators Nov 9, 2020
@chiedo chiedo deleted the jeffmcaffer-patch-2 branch November 30, 2020 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering Will involve Docs Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

developer route redirects load incorrectly on Windows
5 participants