Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product.yml #34109

Closed
wants to merge 1 commit into from
Closed

Update product.yml #34109

wants to merge 1 commit into from

Conversation

parinitaedke
Copy link

Replaced "token" with "tokens" in pat_v2_caps in accordance to issue "Typo in managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token #34104"

Why:

Closes: Issue #34104 -- updating token to tokens in pat_v2_caps. Affects the article "https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token"

What's being changed (if available, include any code snippets, screenshots, or gifs):

Changed token to tokens in pat_v2_caps.

Check off the following:

  • [ x ] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • [ x ] For content changes, I have completed the self-review checklist.

Replaced "token" with "tokens" in pat_v2_caps in accordance to issue "Typo in managing-your-personal-access-tokens#creating-a-fine-grained-personal-access-token github#34104"
Copy link

welcome bot commented Jul 26, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jul 26, 2024
Copy link
Contributor

@nguyenalex836 nguyenalex836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new line here for scenarios requiring pat_v2_caps_plural will ensure situations where only a singular reference of pat_v2_caps remain intact 💛

@@ -111,7 +111,7 @@ pat_generic_title_case: 'Personal Access Token'
pat_generic_title_case_plural: 'Personal Access Tokens'
pat_v2: 'fine-grained personal access token'
pat_v2_plural: 'fine-grained personal access tokens'
pat_v2_caps: 'Fine-grained personal access token'
pat_v2_caps: 'Fine-grained personal access tokens'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pat_v2_caps: 'Fine-grained personal access tokens'
pat_v2_caps: 'Fine-grained personal access token'
pat_v2_caps_plural: 'Fine-grained personal access tokens'

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication and removed triage Do not begin working on this issue until triaged by the team labels Jul 29, 2024
@nguyenalex836
Copy link
Contributor

@parinitaedke Thank you so much for opening a PR! ✨ Many apologies, but I've just received a heads up this particular issues will need to be reviewed and fixed internally 💛

Please feel free to take a look at our help wanted section to find open issues you can work on ✨ Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants