-
Notifications
You must be signed in to change notification settings - Fork 61.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions code example "with" syntax to map instead of array #343
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
👋 @Shegox Thanks for opening a PR! Please fill out the missing section of the PR template "What's being changed," then we can get this triaged for review ✨ |
Hi @janiceilene, updated the section. Please let me know if I should further elaborate that. Thanks. |
Thanks so much @Shegox! I'll get this triaged for review 💝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shegox - many thanks for spotting and fixing these typos ✨
Thanks also for taking the time to fill out the PR summary with details of why you thought the existing docs were wrong - it makes it so much easier to review changes 😄
If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨ |
Why:
The GitHub Action examples on the codeql page (https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning) use the "with" as an array, but this needs to be a map (see the actions docs here).
What's being changed:
Update GitHub Action code snippet on the "configuring code scanning" page to use correct map syntax for the variables in the "with" attribute instead of the array syntax.
Check off the following: