Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node version for service containers #34453

Conversation

hsnabszhdn
Copy link
Contributor

@hsnabszhdn hsnabszhdn commented Aug 31, 2024

Why:

I just followed the instruction for service containers in both Postgres and Redis tutorials, they both throw the following exception when running:

image

Closes:

N/A

What's being changed (if available, include any code snippets, screenshots, or gifs):

I'm changing the container image from node:10.18-jessie to node:20-bookworm-slim (happy to change to something else if there is another suggestion or pattern).

I did confirm that with node:20-bookworm-slim the workflow runs successfully.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 31, 2024
Copy link
Contributor

github-actions bot commented Aug 31, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/migrating-to-github-actions/manually-migrating-to-github-actions/migrating-from-gitlab-cicd-to-github-actions.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
actions/use-cases-and-examples/using-containerized-services/creating-postgresql-service-containers.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
actions/use-cases-and-examples/using-containerized-services/creating-redis-service-containers.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
actions/writing-workflows/about-workflows.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@hsnabszhdn hsnabszhdn force-pushed the upgrade-node-versions-for-service-containers branch from c01d4de to 250d97c Compare August 31, 2024 06:29
@hsnabszhdn hsnabszhdn force-pushed the upgrade-node-versions-for-service-containers branch from 250d97c to 81dfaf2 Compare August 31, 2024 06:37
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Sep 2, 2024
@nguyenalex836
Copy link
Contributor

@hsnabszhdn Thanks so much for opening a PR! I'll get this triaged for review ✨

@subatoi subatoi added the needs SME This proposal needs review from a subject matter expert label Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@hsnabszhdn Thank you for your patience while our team reviewed your PR! They agree with your changes here, and thank you for updating one of our older examples 💛

This repo is currently in a code freeze, but we will get this merged as soon as the freeze ends on 9/16 🍏

@nguyenalex836 nguyenalex836 added ready to merge This pull request is ready to merge SME reviewed An SME has reviewed this issue/PR and removed waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert labels Sep 10, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Sep 16, 2024
Merged via the queue into github:main with commit 33b90d2 Sep 16, 2024
46 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge SME reviewed An SME has reviewed this issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants