Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline#34529 #34533

Closed

Conversation

Swastik-Swarup-Dash
Copy link

Removed layers=inline maybe that raised that issue

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/about-actions-runner-controller.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
pages/getting-started-with-github-pages/changing-the-visibility-of-your-github-pages-site.md ghec
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels Sep 9, 2024
@nguyenalex836
Copy link
Contributor

Hi @Swastik-Swarup-Dash 👋

  • As discussed here, layout: inline was deliberate to avoid a table rendering poorly 💛

  • As we discussed here, unfortunately since your remaining changes are mainly personal preferences on how to phrase something, rather than corrections or improvements, we won't be able to accept this contribution.

@Swastik-Swarup-Dash
Copy link
Author

hi @nguyenalex836 thats cool i totally understand thank u for ur response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants