-
Notifications
You must be signed in to change notification settings - Fork 60.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify "removing secrets from previous commits" section #35235
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lacymorrow - thanks so much for spotting these inaccuracies and omissions ✨
Made a minor change to do with wording that I am going to apply.
...th-secret-scanning-and-push-protection/working-with-push-protection-from-the-command-line.md
Outdated
Show resolved
Hide resolved
…ning-and-push-protection/working-with-push-protection-from-the-command-line.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Thanks folks! I ran into the issue again today 😅 |
What do you mean @lacymorrow? Your updates are in the docs. Do these need further tweaking? |
I think @lacymorrow was expressing gratitude for the update to the docs, as she ran into a scenario again where clarity on these steps helped her 💛 But let me know if I am off! |
Why:
I've run into this issue multiple times.
In the sections to "Removing a secret introduced by...", following the steps as described will not do anything. Git is used by folks who are not get experts, therefore we should describe each step fully.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.