Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update broken link #3536

Merged
merged 2 commits into from
Feb 9, 2021
Merged

fix: update broken link #3536

merged 2 commits into from
Feb 9, 2021

Conversation

xlgmokha
Copy link
Contributor

@xlgmokha xlgmokha commented Feb 7, 2021

Why:

To fix a broken link.

Closes #3535

What's being changed:

This change replaces [] with () because the link is hard coded instead of specified in the index at the bottom of the document.

Screenshot from 2021-02-07 14-09-47

Check off the following:

@welcome
Copy link

welcome bot commented Feb 7, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@xlgmokha xlgmokha marked this pull request as ready for review February 7, 2021 21:17
@xlgmokha
Copy link
Contributor Author

xlgmokha commented Feb 7, 2021

LGTM Staging link

Screenshot from 2021-02-07 14-18-34

The localization checklist says:

Keep inline links to a minimum. If they are necessary, preface them with a phrase such as "For more information, see "Link title". Alternatively, add relevant links to a "Further reading" section at the end of the topic.

I hope it's okay to ignore this because this is modifying an existing inline link.

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @xlgmokha! Thank you so much for opening an issue and a pr for the fix ✨ And you're right, the inline link is 👍 in this case. I'll update the branch and get this merged in once tests are passing 🍏

@janiceilene janiceilene added the ready to merge This pull request is ready to merge label Feb 9, 2021
@janiceilene
Copy link
Contributor

Hm, the tests seem to have stalled. I'm going to close this and reopen it to see if that gets them moving again!

@janiceilene janiceilene closed this Feb 9, 2021
@janiceilene janiceilene reopened this Feb 9, 2021
@janiceilene janiceilene merged commit 6afc62a into github:main Feb 9, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This pull request is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix broken link in "Basics of authentication page"
2 participants