Update Xcode source completion sample #35724
Conversation
Swift prefers camelCase style for functions
|
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
github-actions
bot
added
the
triage
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
nguyenalex836
added
content
|
@jaroshevskii Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Many thanks for raising this pull request to improve our docs. I particularly appreciated your clear description of the problem that you were fixing. ✨
I've made one suggestion to change the language for the code block to Swift, but otherwise this looks good to merge. 🚀
...ent/copilot/using-github-copilot/getting-code-suggestions-in-your-ide-with-github-copilot.md
Outdated
Show resolved
Hide resolved
| @@ -445,8 +445,8 @@ This guide demonstrates how to get coding suggestions from {% data variables.pro | |||
| {% data variables.product.prodname_copilot %} offers coding suggestions as you type. For example, type this function | |||
| signature in a Swift file: | |||
|
|
|||
| ```shell copy | |||
| func CalculateDaysBetweenDates( | |||
| ```swift copy | |||
There was a problem hiding this comment.
Now I see why you didn't use Swift. I'll check why that's not included in our supported languages.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
I've opened:
Once that's approved and merged, we can update your branch and merge this.
felicitymay
removed
the
waiting for review
|
Thanks for your patience @jaroshevskii ✨ My pull request needed a reviewer who's in a later time zone than me. However, that's now merged and your PR is also in the merge queue. Our updates will take a little while to get to production, but should be there before the weekend. |
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
|
The change is live: Getting code suggestions in your IDE with GitHub Copilot |
Swift prefers camelCase style for functions.
Why:
This change ensures consistency with Swift's preferred camelCase naming convention for function names, aligning the documentation with the official Swift coding guidelines.
What's being changed:
The example function signature in the documentation is updated from PascalCase (CalculateDaysBetweenDates) to camelCase (calculateDaysBetweenDates). This adjustment reflects the naming conventions used in Swift:
Before:
After:
Check off the following: