-
Notifications
You must be signed in to change notification settings - Fork 61.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation on on.workflow_run.workflows
#37022
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
on.workflow_run.workflows
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
Thanks so much for opening a PR! I'll get this triaged for review. |
@Sharra-writes thanks for the reply! Please let the team know that I do not see the connection between the Dockerfile |
@EnricoMi Well, no wonder it doesn't seem relevant, because I got my tabs mixed up and put this on the wrong pull request. 😅 I'm so sorry, and thank you for being patient with us. I do have this open for the SMEs to look at. |
Hi @EnricoMi, thanks for raising this—I'm going to reopen the original issue so we can transfer it internally. We'll schedule this work as soon as we can. Just so you're aware, there's a few moving parts to this and I can't guarantee that we'll use this PR: since we need to make some further changes, it may be easier for us to start a new one instead. If we do that, would you like us to add you as a co-committer? I notice you're not using Many thanks |
yes, please |
Why:
The values of
on.workflow_run.workflows
are treated as glob patterns. Special characters requires escaping.Details:
https://github.com/orgs/community/discussions/50835
actions/runner#3763
Closes: #12572
What's being changed (if available, include any code snippets, screenshots, or gifs):
Adds documentation for
on.workflow_run.workflows
, especially around glob patterns.Check off the following: