Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

إضافة وثائق الاتصال الصوتي #37151

Conversation

maryooooooom96
Copy link

@maryooooooom96 maryooooooom96 commented Mar 29, 2025

Add voice communication documentation and update related files.

  • README.md

    • Add a new section for voice communication with a link to the new documentation.
  • content/voice-communication.md

    • Create a new file with detailed documentation on setting up and using voice communication.
  • content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md

    • Add a reference to the new voice communication documentation.
  • src/archives/tests/deprecated-enterprise-versions.ts

    • Add a test case to verify the presence of the new voice communication documentation.

For more details, open the Copilot Workspace session.

Add voice communication documentation and update related files.

* **README.md**
  - Add a new section for voice communication with a link to the new documentation.

* **content/voice-communication.md**
  - Create a new file with detailed documentation on setting up and using voice communication.

* **content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md**
  - Add a reference to the new voice communication documentation.

* **src/archives/tests/deprecated-enterprise-versions.ts**
  - Add a test case to verify the presence of the new voice communication documentation.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/github/docs?shareId=XXXX-XXXX-XXXX-XXXX).
@Copilot Copilot bot review requested due to automatic review settings March 29, 2025 09:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds documentation for voice communication and updates relevant files to reference the new documentation.

  • New voice communication documentation is created.
  • README.md and contributing documentation are updated to include links to the new documentation.
  • A test case is added to verify the presence of the new voice communication documentation.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/archives/tests/deprecated-enterprise-versions.ts Updated cache-control matcher and added test case for voice communication documentation.
content/voice-communication.md New file providing detailed voice communication setup and usage instructions.
content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md Added reference to voice communication documentation.
README.md Added a new section linking to the voice communication documentation.

@@ -336,7 +336,7 @@ describe('JS and CSS assets', () => {
expect(result.headers['x-is-archived']).toBeUndefined()
expect(result.headers['content-type']).toBe('text/plain; charset=utf-8')
expect(result.headers['cache-control']).toContain('public')
expect(result.headers['cache-control']).toMatch(/max-age=[1-9]/)
expect(result.headers['cache-control']).Match(/max-age=[1-9]/)
Copy link
Preview

Copilot AI Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matcher method 'Match' is incorrect; it should be 'toMatch' to properly evaluate the regular expression.

Suggested change
expect(result.headers['cache-control']).Match(/max-age=[1-9]/)
expect(result.headers['cache-control']).toMatch(/max-age=[1-9]/)

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 29, 2025
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • src/archives/tests/deprecated-enterprise-versions.ts

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/deployment/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai.

Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
New file: voice-communication.md

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@Sharra-writes Sharra-writes added invalid This issue/PR is invalid and removed triage Do not begin working on this issue until triaged by the team labels Mar 31, 2025
@github-actions github-actions bot closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This issue/PR is invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants