-
Notifications
You must be signed in to change notification settings - Fork 60.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced "main" by "master" #408
Conversation
The default branch is normally called master, not main.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@tvachkov the change to |
It would be better to name the branch explicitly on init considering the default branch name can be reconfigured. I agree the current guide appears broken. |
I agree on that - main is deliberated. But since the guide advices to call Then one gets the error: src refspec main does not match any. |
@tvachkov i think the right fix would be to change the init call to Also it's pretty evident that |
@tvachkov Thanks for opening a PR and thanks everyone else for the thoughtful conversation about the right wording in this article! I'll triage this for review 💖 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking up what we missed ⚡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving another review because I had the diff backwards. As pointed out, the change from master
to main
was deliberate. We cannot merge any mentions of master
in our content. See https://github.com/github/renaming for more information.
The right solution for this would be to use git init -b main
when a user first initializes a repo. We can publish that change in this PR or you can open a new PR for that change.
Agree with @megbird that |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
@tvachkov Would you like to make the changes @megbird layed out in her comment #408 (review)? Thanks so much for taking the time to help us make these changes 💖 |
Aligning the init command to the push command: both are considering "main" instead of "master"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for making these updates @tvachkov! I'll get this branch updated and merge it once the tests are passing 🍏
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
The default branch is normally called master, not main.
With "main" there is an error:
error: src refspec main does not match any
Why:
What's being changed:
Check off the following: