Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit link raw text contained unnecessary information #460

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

ArnoutDevos
Copy link
Contributor

Why:

Raw reference for "Username/Repository@SHA" contained non-raw things.

What's being changed:

raw text to create commit link

New description is sufficient to create correct short link and is more in line with the other rows.

Check off the following:

Raw reference for "Username/Repository@SHA" contained non-raw things.
New description is sufficient to create correct short link and is more in line with the other rows.
@welcome
Copy link

welcome bot commented Oct 12, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@janiceilene janiceilene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution @ArnoutDevos! I'll get this branch updated and merge it when everything's green 🍏

@janiceilene janiceilene merged commit 050e836 into github:main Oct 12, 2020
@janiceilene
Copy link
Contributor

If you haven't already, you can add yourself to the list of contributors by creating a new comment in this PR using these instructions. Thanks again! ✨

@ArnoutDevos
Copy link
Contributor Author

@all-contributors please add @ArnoutDevos for Documentation

@allcontributors
Copy link
Contributor

@ArnoutDevos

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token ] in JSON at position 8560

@janiceilene
Copy link
Contributor

@all-contributors please add @ArnoutDevos for Documentation

@allcontributors
Copy link
Contributor

@janiceilene

I've put up a pull request to add @ArnoutDevos! 🎉

@janiceilene
Copy link
Contributor

Sorry about that @ArnoutDevos 💛 We had a syntax error that was upsetting the all contributors bot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants