-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate list entry name in about-self-hosted-runners.md #491
Conversation
Fix duplicate list entry
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Thanks so much for opening a PR @wil93! I'll get this triaged for review ⚡ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wil93! Thanks for this change. 🙇♂️
You are right in that there is duplication here, but the {% data reusables.github-actions.usage-matrix-limits %}
reusable is used in a few other places in the docs:
For example:
- https://github.com/wil93/docs/blame/patch-1/content/actions/reference/usage-limits-billing-and-administration.md#L45
- https://github.com/wil93/docs/blame/patch-1/content/actions/reference/workflow-syntax-for-github-actions.md#L764
Because it is used in the Workflow Syntax article without being a list, the best fix for this issue is to remove the - **Job matrix** -
from the reusable file itself:
This reverts commit 058e3da.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks heaps for the fix, @wil93! I'll get this merged in 🚀
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* Reword autoscaling/optimzation content. * Add comma Co-authored-by: Jacob <prall.jacob@gmail.com>
Why:
This list entry has a duplicate name:
What's being changed:
Removed the duplication in a similar way to how it's done in other entries of the same list.
Check off the following: