Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate list entry name in about-self-hosted-runners.md #491

Merged
merged 5 commits into from
Oct 18, 2020
Merged

Fix duplicate list entry name in about-self-hosted-runners.md #491

merged 5 commits into from
Oct 18, 2020

Conversation

wil93
Copy link
Contributor

@wil93 wil93 commented Oct 13, 2020

Why:

This list entry has a duplicate name:

image

What's being changed:

Removed the duplication in a similar way to how it's done in other entries of the same list.

Check off the following:

Fix duplicate list entry
@welcome
Copy link

welcome bot commented Oct 13, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @wil93! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Oct 13, 2020
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wil93! Thanks for this change. 🙇‍♂️

You are right in that there is duplication here, but the {% data reusables.github-actions.usage-matrix-limits %} reusable is used in a few other places in the docs:

For example:

Because it is used in the Workflow Syntax article without being a list, the best fix for this issue is to remove the - **Job matrix** - from the reusable file itself:

https://github.com/github/docs/blame/main/data/reusables/github-actions/usage-matrix-limits.md#L1

@lucascosti lucascosti self-assigned this Oct 16, 2020
@wil93 wil93 requested a review from lucascosti October 16, 2020 13:57
Copy link
Contributor

@lucascosti lucascosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks heaps for the fix, @wil93! I'll get this merged in 🚀

@lucascosti lucascosti merged commit ad76903 into github:main Oct 18, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@wil93 wil93 deleted the patch-1 branch October 19, 2020 07:27
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
* Reword autoscaling/optimzation content.

* Add comma

Co-authored-by: Jacob <prall.jacob@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants