Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elaborate on how to escape multiple labels in issue templates #519

Merged
merged 4 commits into from
Oct 21, 2020
Merged

Elaborate on how to escape multiple labels in issue templates #519

merged 4 commits into from
Oct 21, 2020

Conversation

MortenBoysen
Copy link
Contributor

Why:

Escaping them individually led to bugs in our templates that I had to spend time on tracking down.

What's being changed:

The description on how to change labels in issue templates

Check off the following:

Escaping them individually led to bugs in our templates that I had to spend time on tracking down.
@welcome
Copy link

welcome bot commented Oct 14, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@janiceilene
Copy link
Contributor

Thanks so much for opening a PR @MortenBoysen! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 15, 2020
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to hear that this cost you time debugging your template but many thanks for submitting a fix to stop it affecting others 💖

@felicitymay
Copy link
Contributor

👋🏻 Hi @MortenBoysen - before I merge this PR, I'd really like to know your thoughts on my suggested change to introductory text. Would that have been any clearer?

…-single-issue-template-for-your-repository.md

Co-authored-by: Felicity Chapman <felicitymay@github.com>
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@felicitymay felicitymay merged commit 2a80dd1 into github:main Oct 21, 2020
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@felicitymay felicitymay added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants