-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update https-cloning-errors.md #553
Conversation
Partially fixes github#429
👋 Thanks @casals! I'll get this triaged for review 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @casals - thanks for your analysis of the related issue. 💎
Your suggestion of including the troubleshooting information in the tip seems good. I've made a small suggestion to the text, but otherwise this looks ready to merge.
content/github/creating-cloning-and-archiving-repositories/https-cloning-errors.md
Outdated
Show resolved
Hide resolved
…ps-cloning-errors.md Added suggested changes Co-authored-by: Felicity Chapman <felicitymay@github.com>
Thanks for raising the two new issues for the remaining work on this issue 😄 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
* Add nft starter kit tutorial * Suggestions from review part 1 * Suggestions from review part 2 * Suggestions from review part 3 Co-authored-by: Lana Brindley <github@lanabrindley.com> * Suggestions from review part 4 Co-authored-by: Lana Brindley <github@lanabrindley.com> * Sample dataset note * Quotes fix * Descriptions above tables * Unspacing tables * Move description above table + links * Add links * Add links * Minor fix * Update EON NFT copy part 2 * Fix title * Remove duplacation * Wrap long lines at around 80 chars * Smart apostrophe * Remove HAVING clause * Fix links * Revert "Merge branch 'nft-starter-kit' of https://github.com/timescale/docs into nft-starter-kit" This reverts commit f4614b0983b120346e22394a323ce08c232d2f30, reversing changes made to 26d4918a71b4da4bef7ac8cabc5f306faa5ceb60. * where clause fix * Minor fix * Update starter kit components text * Revert "Revert "Merge branch 'nft-starter-kit' of https://github.com/timescale/docs into nft-starter-kit"" This reverts commit 84f2b3e60546da7be37a78ebb0cb15acebbf3873. * Update ingest script instructions * Fix file name * Minor tweaks * Ingest procedure minor update * fix link * Add link * Remove between in where clause Co-authored-by: Ryan Booz <ryan@timescale.com> * Fix CSV file names * Faster query Co-authored-by: Ryan Booz <ryan@timescale.com> Co-authored-by: Lana Brindley <github@lanabrindley.com> Co-authored-by: Jacob Prall <prall.jacob@gmail.com> Co-authored-by: Ryan Booz <ryan@timescale.com>
Why:
Partially fixes #429
What's being changed:
Fixed the existing documentation on HTTPS Cloning Errors and Cached Credentials to include the author's suggestion. Since "incorrect or out of date credentials cached" depends on the developer choosing to use password caching, I opted for extending the existing tip note instead of complementing the introductory paragraph (just to keep things within the same context).
Please note that this PR only fixes one of the possible three alterations required by this issue, as described/proposed in this comment.
Check off the following: