-
Notifications
You must be signed in to change notification settings - Fork 62.6k
Update about-github-pages.md #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lately i'm working on an unofficial Chinese translation of GitHub Pages docs due to the incompletion of the original and currently there is no way to contribute translations to the docs. So, I hope that's ok to you guys. The thing is, I'm seeing that this document is using both `<user>` and `<username>` as subdomain pronouns among the context. It's not a big problem, but in my opnion, this might cause some unnecessary confusion to some users. If it was intended to be so, I'd like to know why? Thank you!
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that should be replaced with , hence approval.
@@ -33,9 +33,9 @@ Organization owners can disable the publication of {% data variables.product.pro | |||
|
|||
There are three types of {% data variables.product.prodname_pages %} sites: project, user, and organization. Project sites are connected to a specific project hosted on {% data variables.product.product_name %}, such as a JavaScript library or a recipe collection. User and organization sites are connected to a specific {% data variables.product.product_name %} account. | |||
|
|||
To publish a user site, you must create a repository owned by your user account that's named {% if currentVersion == "free-pro-team@latest" %}`<user>.github.io`{% else %}`<user>.<hostname>`{% endif %}. To publish an organization site, you must create a repository owned by an organization that's named {% if currentVersion == "free-pro-team@latest" %}`<organization>.github.io`{% else %}`<organization>.<hostname>`{% endif %}. {% if currentVersion == "free-pro-team@latest" %}Unless you're using a custom domain, user and organization sites are available at `http(s)://<username>.github.io` or `http(s)://<organization>.github.io`.{% endif %} | |||
To publish a user site, you must create a repository owned by your user account that's named {% if currentVersion == "free-pro-team@latest" %}`<username>.github.io`{% else %}`<username>.<hostname>`{% endif %}. To publish an organization site, you must create a repository owned by an organization that's named {% if currentVersion == "free-pro-team@latest" %}`<organization>.github.io`{% else %}`<organization>.<hostname>`{% endif %}. {% if currentVersion == "free-pro-team@latest" %}Unless you're using a custom domain, user and organization sites are available at `http(s)://<username>.github.io` or `http(s)://<organization>.github.io`.{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change!
👋 Thanks for opening a PR @jw-12138! This is now triaged for review. Sorry about the delay, I somehow missed this PR 💛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
@jw-12138 - Thank you for this pull request. That's a good change. Currently were not merging pull requests, but we'll start doing so again very soon and I'll get this merged. Thanks again for helping to improve GitHub's documentation. 👍 You're right about the non-English versions of pages. Unfortunately, we're not currently able to accept pull requests for translated content. Our translation process involves an integration with an external service at crowdin.com, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we're not there yet. |
Thanks for replying! Also, about Anyway, Thank you! |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
Lately i'm working on an unofficial Chinese translation of GitHub Pages docs due to the incompletion of the original and currently there is no way to contribute translations to the docs. So, I hope that's ok to you guys.
What's being changed:
The thing is, I'm seeing that this document is using both
<user>
and<username>
as subdomain pronouns among the context. It's not a big problem, but in my opinion, this might cause some unnecessary confusion to some users.If it was intended to be so, I'd like to know why?
Thank you!
Check off the following: