Skip to content

Update about-github-pages.md #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Update about-github-pages.md #734

merged 4 commits into from
Nov 3, 2020

Conversation

jw-12138
Copy link
Contributor

@jw-12138 jw-12138 commented Oct 23, 2020

Why:

Lately i'm working on an unofficial Chinese translation of GitHub Pages docs due to the incompletion of the original and currently there is no way to contribute translations to the docs. So, I hope that's ok to you guys.

What's being changed:

The thing is, I'm seeing that this document is using both <user> and <username> as subdomain pronouns among the context. It's not a big problem, but in my opinion, this might cause some unnecessary confusion to some users.

If it was intended to be so, I'd like to know why?
Thank you!

Check off the following:

Lately i'm working on an unofficial Chinese translation of GitHub Pages docs due to the incompletion of the original and currently there is no way to contribute translations to the docs. So,  I hope that's ok to you guys.  

The thing is, I'm seeing that this document is using both `<user>` and `<username>` as subdomain pronouns among the context. It's not a big problem, but in my opnion, this might cause some unnecessary confusion to some users.   

If it was intended to be so, I'd like to know why?  
Thank you!
@welcome
Copy link

welcome bot commented Oct 23, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that should be replaced with , hence approval.

@@ -33,9 +33,9 @@ Organization owners can disable the publication of {% data variables.product.pro

There are three types of {% data variables.product.prodname_pages %} sites: project, user, and organization. Project sites are connected to a specific project hosted on {% data variables.product.product_name %}, such as a JavaScript library or a recipe collection. User and organization sites are connected to a specific {% data variables.product.product_name %} account.

To publish a user site, you must create a repository owned by your user account that's named {% if currentVersion == "free-pro-team@latest" %}`<user>.github.io`{% else %}`<user>.<hostname>`{% endif %}. To publish an organization site, you must create a repository owned by an organization that's named {% if currentVersion == "free-pro-team@latest" %}`<organization>.github.io`{% else %}`<organization>.<hostname>`{% endif %}. {% if currentVersion == "free-pro-team@latest" %}Unless you're using a custom domain, user and organization sites are available at `http(s)://<username>.github.io` or `http(s)://<organization>.github.io`.{% endif %}
To publish a user site, you must create a repository owned by your user account that's named {% if currentVersion == "free-pro-team@latest" %}`<username>.github.io`{% else %}`<username>.<hostname>`{% endif %}. To publish an organization site, you must create a repository owned by an organization that's named {% if currentVersion == "free-pro-team@latest" %}`<organization>.github.io`{% else %}`<organization>.<hostname>`{% endif %}. {% if currentVersion == "free-pro-team@latest" %}Unless you're using a custom domain, user and organization sites are available at `http(s)://<username>.github.io` or `http(s)://<organization>.github.io`.{% endif %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change!

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! localization Issue or PR relating to translation or localization labels Oct 27, 2020
@janiceilene
Copy link
Contributor

👋 Thanks for opening a PR @jw-12138! This is now triaged for review. Sorry about the delay, I somehow missed this PR 💛

Copy link

@dennispan dennispan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hubwriter
Copy link
Contributor

@jw-12138 - Thank you for this pull request. That's a good change. Currently were not merging pull requests, but we'll start doing so again very soon and I'll get this merged. Thanks again for helping to improve GitHub's documentation. 👍

You're right about the non-English versions of pages. Unfortunately, we're not currently able to accept pull requests for translated content. Our translation process involves an integration with an external service at crowdin.com, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we're not there yet.

@hubwriter hubwriter self-assigned this Oct 29, 2020
@jw-12138
Copy link
Contributor Author

@jw-12138 - Thank you for this pull request. That's a good change. Currently were not merging pull requests, but we'll start doing so again very soon and I'll get this merged. Thanks again for helping to improve GitHub's documentation. 👍

You're right about the non-English versions of pages. Unfortunately, we're not currently able to accept pull requests for translated content. Our translation process involves an integration with an external service at crowdin.com, where all translation activity happens. We hope to eventually open up the translation process to the open-source community, but we're not there yet.

Thanks for replying!
This is in fact the first official PR I did, looks like it's a good start!
I'll keep doing my best as you guys doing out there! 👍

Also, about Crowdin, It might be offensive to say so, a good translation should use both experiences and skills, I don't think every Crowdin user is actually using the product they translate...do they? (🤣 that's a lot on me). But hey, it's a very cool platform! I've registered my account and hoping to get started to do something very soon.

Anyway, Thank you!

@hubwriter hubwriter merged commit e4796fe into github:main Nov 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! localization Issue or PR relating to translation or localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants