Added build step to prepare script

[FarazzShaikh]

Added build step to prepare script and Removed redundant calls of build script

Why:

Closes #222

What's being changed:

Check off the following:

• I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
• For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

• This pull request impacts the contribution experience
  • I have added the 'writer impact' label
  • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

[welcome]

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[github-actions]

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.github/actions-scripts/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
lib/graphql/**
lib/redirects/**
lib/rest/**
lib/webhooks/**
scripts/**
translations/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process.

[FarazzShaikh]

I have added npm run build to the prepare script in package.json. As a result, I have attempted to remove all redundant calls of npm run build.

However, there are some calls that I am not sure how to handle. Here are they:

• https://github.com/FarazzShaikh/docs/blob/b08a65a90373d6cd92604b7ca63d6fd78b5a1265/.github/workflows/sync-single-english-algolia-index.yml#L51
• https://github.com/FarazzShaikh/docs/blob/b08a65a90373d6cd92604b7ca63d6fd78b5a1265/.github/workflows/test-windows.yml#L64
• https://github.com/FarazzShaikh/docs/blob/b08a65a90373d6cd92604b7ca63d6fd78b5a1265/.github/workflows/test.yml#L69
• https://github.com/FarazzShaikh/docs/blob/b08a65a90373d6cd92604b7ca63d6fd78b5a1265/script/enterprise-server-deprecations/archive-version.js#L110
• https://github.com/FarazzShaikh/docs/blob/b08a65a90373d6cd92604b7ca63d6fd78b5a1265/Dockerfile#L58

And maybe other that I might have missed. These calls perform some operations after npm ci and before npm run build.

@JamesMGreene @zeke

[janiceilene]

@FarazzShaikh Thanks so much for opening a PR! I'll get this triaged for review ⚡

[github-actions]

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

[janiceilene]

Thanks for opening this PR @FarazzShaikh! Sometimes we need to run packages without making a build, having to build to install would be a deal breaker for some processes, so we can't accept this PR.

Thanks so much for your interest and passion in improving the GitHub docs 💛

[FarazzShaikh]

@janiceilene thank you for your review. You should close #222 as well if this cannot be implemented.

[JamesMGreene]

@FarazzShaikh We really appreciate the PR you offered up. 🙇🏻‍♂️

Unfortunately, when the larger team reviewed your PR, one of the valid issues mentioned was that this change (adding a prepare script to run the npm run build script) would've forced us to always run the build, even when we don't want or need to, and thus slowing down certain processes (e.g. in many of our Actions workflows). That was a perspective that I hadn't considered when I encouraged you to create this PR. 😓

Since npm does not currently provide us a mechanism to opt-out of that behavior (other than --ignore-scripts, which also ignores all of the dependencies' lifecycle scripts, too 😬 🙅🏻‍♂️), we decided it was better for us to stick with the opt-in behavior that we currently have. While we understand that does put a slight burden on contributors to execute that one extra step, we believe it is something that is easily enough learned and worked around. 🤷🏻‍♂️

Thank you especially for your thoroughness in taking the extra step of updating the contributor documentation, the Codespaces configuration, and the Actions workflows as well. ✨

We are thankful for your involvement and effort. We would love to see additional contributions from you in the future. ❤️

[FarazzShaikh]

Understood, Thanks for letting me know! 😄