Skip to content

Conversation

@bnb
Copy link
Contributor

@bnb bnb commented Oct 27, 2020

Why:

When I was less experienced, I absolutely would have gotten confused by usage of main in a repo where main isn't the default branch. Since GitHub has landed on default branch as the phrasing for the concept, I've gone ahead and updated this to specifically call out default branch in a way that still uses main as an example.

What's being changed:

Prose around main, giving more context that main is just the default branch for this specific example.

Check off the following:

@janiceilene
Copy link
Contributor

Thanks for opening a PR @bnb! I'll get this triaged for review ⚡

@janiceilene janiceilene added content This issue or pull request belongs to the Docs Content team core labels Oct 29, 2020
The point being made in step 3 is a general one that applies to all branches, so I've modified a sentence slightly.
Corrected a typo in step 5.
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bnb - This is a good change. Many thanks for submitting this. We really appreciate your help improving GitHub documentation.

We'll get this change merged in very soon.

@hubwriter hubwriter self-assigned this Nov 2, 2020
@hubwriter hubwriter merged commit 7407320 into github:main Nov 3, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@bnb
Copy link
Contributor Author

bnb commented Nov 9, 2020

Thanks, y'all! ❤️

@bnb bnb deleted the patch-2 branch November 9, 2020 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants