-
Notifications
You must be signed in to change notification settings - Fork 60.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example for self-hosted runners in the wild #9015
Conversation
there are probably no examples of self-hosted runners whose service name is `actions.runner.octo-org-octo-repo.runner01.service` outside of octo-org. this change includes a command example that works in the wild.
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@grenade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grenade - Many thanks for taking the time to make this improvement to the GitHub docs. Much appreciated. 👍
Apologies it's taken a while to get round to reviewing this. You make a good point here and this is a good improvement. Thanks again for your input.
I've suggested some very small changes, which hopefully you're okay with. If you're happy to commit these suggestions we can get this merged and published.
Thanks once again. 🎖
content/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
content/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
After some discussion about this internally here at GitHub, I'm going to omit the second part of the changes proposed in this pull request (i.e. the additional journalctl and systemctl commands in the code blocks on lines 70 and 207). Introducing an example org/repo and then using that example throughout the article is consistent with our other docs and hasn't been difficult for readers to switch in their own org/repo names for the example ones (in this case I'll make these changes in this PR so that I can merge the other changes. |
…eshooting-self-hosted-runners.md
…eshooting-self-hosted-runners.md
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
|
content/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
content/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
content/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
content/actions/hosting-your-own-runners/monitoring-and-troubleshooting-self-hosted-runners.md
Outdated
Show resolved
Hide resolved
…eshooting-self-hosted-runners.md
…eshooting-self-hosted-runners.md
…eshooting-self-hosted-runners.md
…eshooting-self-hosted-runners.md
there are probably no examples of self-hosted runners whose service name is
actions.runner.octo-org-octo-repo.runner01.service
outside of octo-org.the other problem with the current docs is the suggestion to use
cat ~/actions-runner/.service
to determine the service name. obviously this only works if the installation path was~/actions-runner/.service
which is only ever going to be coincidentally correct.this change includes a command example that works in the wild and is based on using
systemctl --type=service | grep actions.runner
to determine the service name which is generally going to work (if the user has managed to gt the service running).Why:
Closes [issue link]
What's being changed:
Check off the following:
Writer impact (This section is for GitHub staff members only):