Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Faraday::Error::* usage #309

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Replace Faraday::Error::* usage #309

merged 3 commits into from
Apr 10, 2024

Conversation

jasonkim
Copy link
Contributor

@jasonkim jasonkim commented Apr 5, 2024 •
edited
Loading

  • Replace Faraday::Error::* with Faraday::* error classes (following the upgrade guide)
  • Handle all Faraday::Error instead of Faraday::Error::ClientError
  • Unlock faraday version to allow 1.0.0
  • Bumped up the faraday and faraday middleware gems slightly

@jasonkim jasonkim force-pushed the make-faraday-upgrade-compatible branch from 8969f3d to ef010b0 Compare April 6, 2024 01:14
@jasonkim jasonkim marked this pull request as ready for review April 6, 2024 01:22
tomthorogood
tomthorogood reviewed Apr 8, 2024
View reviewed changes
Copy link

@tomthorogood tomthorogood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this looks just fine to me, I've only mucked around here once or twice, and feel as though @ndonewar, @richa-d, or @kag728 are in a better place to know whether this could have any undesired side effects.

Just wanted to let you know I looked, at least! 😅

@jasonkim jasonkim requested a review from richa-d April 8, 2024 16:16
ndonewar
ndonewar reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@ndonewar ndonewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor suggestions about bumping the minor version, but otherwise looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
lib/elastomer_client/version.rb Outdated Show resolved Hide resolved
jasonkim and others added 2 commits April 9, 2024 10:54
@jasonkim jasonkim force-pushed the make-faraday-upgrade-compatible branch from ae742d6 to 173991d Compare April 9, 2024 18:18
@jasonkim jasonkim requested a review from ndonewar April 9, 2024 18:44
@jasonkim jasonkim merged commit 791a473 into main Apr 10, 2024
3 checks passed
@jasonkim jasonkim deleted the make-faraday-upgrade-compatible branch April 10, 2024 00:27
composerinteralia added a commit that referenced this pull request Jun 5, 2024
@composerinteralia
Unlock faraday_middleware version
d0164d7 
This is a followup to #309

We can't upgrade faraday to 1.x without also upgrading
faraday_middleware to 1.x, so the previous PR didn't get us all the way
there.

Not much changes in faraday_middleware 1.x except for faraday 1.x
support, so I expect elastomer-client to be fully compatible.

(We'll revisit this once more for faraday 2.0, which drops the
faraday_middleware gem entirely, but that's a problem for another day.)
@composerinteralia composerinteralia mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomthorogood tomthorogood tomthorogood left review comments

@ndonewar ndonewar ndonewar approved these changes

@kag728 kag728 Awaiting requested review from kag728

@richa-d richa-d Awaiting requested review from richa-d

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonkim @ndonewar @tomthorogood