Don't delete all of attributes

github · Jul 10, 2023 · 95c60cf · 95c60cf
1 parent 951feea
commit 95c60cf
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/lib/rules/role-supports-aria-props.js b/lib/rules/role-supports-aria-props.js
@@ -9,7 +9,10 @@ const elementRolesMap = new ObjectMap()
 for (const [key, value] of elementRoles.entries()) {
   // - Remove unused `constraints` key
   delete key.constraints
-  key.attributes = key.attributes?.filter(attribute => !('constraints' in attribute))
+  // - Remove `constraints` key within `attributes`
+  for (const attribute of key.attributes || []) {
+    delete attribute.constraints
+  }
   // - Remove empty `attributes` key
   if (!key.attributes || key.attributes?.length === 0) {
     delete key.attributes