Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change typescript rules #104

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Change typescript rules #104

merged 2 commits into from
Apr 3, 2020

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Apr 1, 2020

eae37ab

@typescript-eslint already includes a no-unused-vars rule so we use that one instead.

be71c95

I think we want to just allow people to name their interfaces whatever they want.

@koddsson koddsson added this to the 4.0.0 milestone Apr 1, 2020
@koddsson koddsson requested a review from a team as a code owner April 1, 2020 16:37
@keithamus
Copy link
Member

keithamus commented Apr 2, 2020

@typescript-eslint already includes a no-unused-vars rule so we use that one instead.

For posterity - we extend from @typescript-eslint/recommended which includes the @typescript/no-unused-vars rule.

I think we want to just allow people to name their interfaces whatever they want.

The same config also has the @typescript/interface-name-prefix rule set, which we're disabling here.

@koddsson koddsson merged commit 9f552f1 into master Apr 3, 2020
@koddsson koddsson deleted the change-typescript-rules branch April 3, 2020 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants