Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump the all-dependencies group with 7 updates #447

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2023

Bumps the all-dependencies group with 7 updates:

Package Update
@typescript-eslint/eslint-plugin 5.59.2 to 5.61.0
@typescript-eslint/parser 5.59.2 to 5.61.0
aria-query 5.1.3 to 5.3.0
jsx-ast-utils 3.3.3 to 3.3.4
prettier 2.8.8 to 3.0.0
eslint 8.40.0 to 8.44.0
eslint-plugin-eslint-plugin 5.0.8 to 5.1.0

Updates @typescript-eslint/eslint-plugin from 5.59.2 to 5.61.0

Release notes

Sourced from @​typescript-eslint/eslint-plugin's releases.

v5.61.0

5.61.0 (2023-07-03)

Features

  • eslint-plugin: [ban-types] ban types in extends and implements (#7129) (997783f)
  • support TypeScript 5.1 (#7088) (4bf2d73)
  • use graphemer instead of grapheme-splitter (#7069) (faea3ff)

You can read about our versioning strategy and releases on our website.

v5.60.1

5.60.1 (2023-06-26)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

You can read about our versioning strategy and releases on our website.

v5.60.0

5.60.0 (2023-06-19)

Features

  • eslint-plugin: [restrict-plus-operands] add allow* options (#6161) (def09f8)

v5.59.11

5.59.11 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.10

5.59.10 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.9

5.59.9 (2023-06-05)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.8

5.59.8 (2023-05-29)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.7

5.59.7 (2023-05-22)

... (truncated)

Changelog

Sourced from @​typescript-eslint/eslint-plugin's changelog.

5.61.0 (2023-07-03)

Features

  • eslint-plugin: [ban-types] ban types in extends and implements (#7129) (997783f)
  • use graphemer instead of grapheme-splitter (#7069) (faea3ff)

You can read about our versioning strategy and releases on our website.

5.60.1 (2023-06-26)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

You can read about our versioning strategy and releases on our website.

5.60.0 (2023-06-19)

Features

  • eslint-plugin: [restrict-plus-operands] add allow* options (#6161) (def09f8)

5.59.11 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

5.59.10 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/eslint-plugin

... (truncated)

Commits
  • 2f46341 chore: publish v5.61.0
  • 997783f feat(eslint-plugin): [ban-types] ban types in extends and implements (#7129)
  • faea3ff feat: use graphemer instead of grapheme-splitter (#7069)
  • f74862c chore: publish v5.60.1
  • c09b1c0 chore: publish v5.60.0
  • def09f8 feat(eslint-plugin): [restrict-plus-operands] add allow* options (#6161)
  • a91bb9e chore: publish v5.59.11
  • 9768e98 chore: publish v5.59.10
  • a2b6b2e chore: publish v5.59.9
  • 4710a22 chore: update to latest nx and lerna (#7019)
  • Additional commits viewable in compare view

Updates @typescript-eslint/parser from 5.59.2 to 5.61.0

Release notes

Sourced from @​typescript-eslint/parser's releases.

v5.61.0

5.61.0 (2023-07-03)

Features

  • eslint-plugin: [ban-types] ban types in extends and implements (#7129) (997783f)
  • support TypeScript 5.1 (#7088) (4bf2d73)
  • use graphemer instead of grapheme-splitter (#7069) (faea3ff)

You can read about our versioning strategy and releases on our website.

v5.60.1

5.60.1 (2023-06-26)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

You can read about our versioning strategy and releases on our website.

v5.60.0

5.60.0 (2023-06-19)

Features

  • eslint-plugin: [restrict-plus-operands] add allow* options (#6161) (def09f8)

v5.59.11

5.59.11 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.10

5.59.10 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.9

5.59.9 (2023-06-05)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.8

5.59.8 (2023-05-29)

Note: Version bump only for package @​typescript-eslint/typescript-eslint

v5.59.7

5.59.7 (2023-05-22)

... (truncated)

Changelog

Sourced from @​typescript-eslint/parser's changelog.

5.61.0 (2023-07-03)

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

5.60.1 (2023-06-26)

Note: Version bump only for package @​typescript-eslint/parser

You can read about our versioning strategy and releases on our website.

5.60.0 (2023-06-19)

Note: Version bump only for package @​typescript-eslint/parser

5.59.11 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/parser

5.59.10 (2023-06-12)

Note: Version bump only for package @​typescript-eslint/parser

5.59.9 (2023-06-05)

Note: Version bump only for package @​typescript-eslint/parser

... (truncated)

Commits

Updates aria-query from 5.1.3 to 5.3.0

Changelog

Sourced from aria-query's changelog.

5.3.0

Reverts some API data shape changes from 5.2.x. Also reverts some changes to the representation of the ARIA spec.

  • fda2c97 fix: amend breaking changes and reinstate constraints (#515)
  • f9f9ea6 Add prepublishOnly step to package.json (#506)
Commits

Updates jsx-ast-utils from 3.3.3 to 3.3.4

Changelog

Sourced from jsx-ast-utils's changelog.

v3.3.4 - 2023-06-28

Commits

  • [Refactor] use array.prototype.flat object.values over .reduce bad51d0
  • [meta] add auto-changelog af1de69
  • [Tests] add test for import.meta 1d39f58
  • [Dev Deps] update @babel/core, @babel/eslint-parser, @babel/parser, aud, eslint, eslint-plugin-import 3baaf76
  • [Fix] TSNonNullExpression: Handle function calls 26cc3c4
  • [Dev Deps] update eslint, @babel/core, @babel/parser, object.entries, object.fromentries 0e4f80c
  • [Dev Deps] update @babel/core, @babel/eslint-parser, @babel/parser, aud b5427a6
  • [meta] run build in prepack, not prepublish a0f4f38
  • [Deps] update array-includes c479841
  • [Deps] update object.assign 9685dce
Commits
  • fa8a5e8 v3.3.4
  • bad51d0 [Refactor] use array.prototype.flat object.values over .reduce
  • 3baaf76 [Dev Deps] update @babel/core, @babel/eslint-parser, @babel/parser, `au...
  • 1d39f58 [Tests] add test for import.meta
  • 26cc3c4 [Fix] TSNonNullExpression: Handle function calls
  • a0f4f38 [meta] run build in prepack, not prepublish
  • c479841 [Deps] update array-includes
  • 0e4f80c [Dev Deps] update eslint, @babel/core, @babel/parser, object.entries,...
  • af1de69 [meta] add auto-changelog
  • 9685dce [Deps] update object.assign
  • Additional commits viewable in compare view

Updates prettier from 2.8.8 to 3.0.0

Release notes

Sourced from prettier's releases.

3.0.0

diff

🔗 Release note

3.0.0-alpha.6

What's Changed

Other changes since v2, see 3.0.0-alpha.1 release notes

Full Changelog: prettier/prettier@3.0.0-alpha.5...3.0.0-alpha.6

3.0.0-alpha.5

What's Changed

Other changes since v2, see 3.0.0-alpha.1 release notes

Full Changelog: prettier/prettier@3.0.0-alpha.4...3.0.0-alpha.5

3.0.0-alpha.4

What's Changed

Other changes since v2, see 3.0.0-alpha.1 release notes

Full Changelog: prettier/prettier@3.0.0-alpha.3...3.0.0-alpha.4

3.0.0-alpha.3

  • Fix exports field in package.json file

Other changes since v2, see 3.0.0-alpha.1 release notes

Full Changelog: prettier/prettier@3.0.0-alpha.2...3.0.0-alpha.3

3.0.0-alpha.2

  • Fix bundled index.cjs file

Other changes since v2, see 3.0.0-alpha.1 release notes

Full Changelog: prettier/prettier@3.0.0-alpha.1...3.0.0-alpha.2

3.0.0-alpha.1

If you are a plugin developer, please try this version and send us feedback! Feel free to ping @​fisker if you have any questions about v3 migration.

... (truncated)

Changelog

Sourced from prettier's changelog.

3.0.0

diff

🔗 Release Notes

Commits

Updates eslint from 8.40.0 to 8.44.0

Release notes

Sourced from eslint's releases.

v8.44.0

Features

  • 1766771 feat: add es2023 and es2024 environments (#17328) (Milos Djermanovic)
  • 4c50400 feat: add ecmaVersion: 2024, regexp v flag parsing (#17324) (Milos Djermanovic)
  • 4d411e4 feat: add ternaryOperandBinaryExpressions option to no-extra-parens rule (#17270) (Percy Ma)
  • c8b1f4d feat: Move parserServices to SourceCode (#17311) (Milos Djermanovic)
  • ef6e24e feat: treat unknown nodes as having the lowest precedence (#17302) (Brad Zacher)
  • 1866e1d feat: allow flat config files to export a Promise (#17301) (Milos Djermanovic)

Bug Fixes

  • a36bcb6 fix: no-unused-vars false positive with logical assignment operators (#17320) (Gweesin Chan)
  • 7620b89 fix: Remove no-unused-labels autofix before potential directives (#17314) (Francesco Trotta)
  • 391ed38 fix: Remove no-extra-semi autofix before potential directives (#17297) (Francesco Trotta)

Documentation

  • 526e911 docs: resubmit pr 17115 doc changes (#17291) (唯然)
  • e1314bf docs: Integration section and tutorial (#17132) (Ben Perlmutter)
  • 19a8c5d docs: Update README (GitHub Actions Bot)

Chores

  • 49e46ed chore: upgrade @​eslint/js@​8.44.0 (#17329) (Milos Djermanovic)
  • a1cb642 chore: package.json update for @​eslint/js release (ESLint Jenkins)
  • 840a264 test: More test cases for no-case-declarations (#17315) (Elian Cordoba)
  • e6e74f9 chore: package.json update for eslint-config-eslint release (ESLint Jenkins)
  • eb3d794 chore: upgrade semver@7.5.3 (#17323) (Ziyad El Abid)
  • cf88439 chore: upgrade optionator@0.9.3 (#17319) (Milos Djermanovic)
  • 9718a97 refactor: remove unnecessary code in flat-eslint.js (#17308) (Milos Djermanovic)
  • f82e56e perf: various performance improvements (#17135) (moonlightaria)
  • da81e66 chore: update eslint-plugin-jsdoc to 46.2.5 (#17245) (唯然)
  • b991640 chore: switch eslint-config-eslint to the flat format (#17247) (唯然)

v8.43.0

Features

  • 14581ff feat: directive prologue detection and autofix condition in quotes (#17284) (Francesco Trotta)
  • e50fac3 feat: add declaration loc to message in block-scoped-var (#17252) (Milos Djermanovic)
  • 1b7faf0 feat: add skipJSXText option to no-irregular-whitespace rule (#17182) (Azat S)

Bug Fixes

  • 5338b56 fix: normalize cwd passed to ESLint/FlatESLint constructor (#17277) (Milos Djermanovic)
  • 54383e6 fix: Remove no-extra-parens autofix for potential directives (#17022) (Francesco Trotta)

Documentation

  • 8b855ea docs: resubmit pr17061 doc changes (#17292) (唯然)
  • 372722e docs: resubmit pr17012 doc changes (#17293) (唯然)
  • 67e7af3 docs: resubmit custom-rules doc changes (#17294) (唯然)
  • 9e3d77c docs: Resubmit Fix formatting in Custom Rules docs (#17281) (Milos Djermanovic)
  • 503647a docs: Resubmit markVariableAsUsed docs (#17280) (Nicholas C. Zakas)
  • e0cf0d8 docs: Custom rule & plugin tutorial (#17024) (Ben Perlmutter)
  • 8e51ea9 docs: resubmit no-new rule documentation (#17264) (Nitin Kumar)
  • 1b217f8 docs: resubmit Custom Processors documentation (#17265) (Nitin Kumar)

... (truncated)

Changelog

Sourced from eslint's changelog.

v8.44.0 - June 30, 2023

  • 49e46ed chore: upgrade @​eslint/js@​8.44.0 (#17329) (Milos Djermanovic)
  • a1cb642 chore: package.json update for @​eslint/js release (ESLint Jenkins)
  • 1766771 feat: add es2023 and es2024 environments (#17328) (Milos Djermanovic)
  • 4c50400 feat: add ecmaVersion: 2024, regexp v flag parsing (#17324) (Milos Djermanovic)
  • 4d411e4 feat: add ternaryOperandBinaryExpressions option to no-extra-parens rule (#17270) (Percy Ma)
  • 840a264 test: More test cases for no-case-declarations (#17315) (Elian Cordoba)
  • e6e74f9 chore: package.json update for eslint-config-eslint release (ESLint Jenkins)
  • eb3d794 chore: upgrade semver@7.5.3 (#17323) (Ziyad El Abid)
  • a36bcb6 fix: no-unused-vars false positive with logical assignment operators (#17320) (Gweesin Chan)
  • c8b1f4d feat: Move parserServices to SourceCode (#17311) (Milos Djermanovic)
  • cf88439 chore: upgrade optionator@0.9.3 (#17319) (Milos Djermanovic)
  • 7620b89 fix: Remove no-unused-labels autofix before potential directives (#17314) (Francesco Trotta)
  • ef6e24e feat: treat unknown nodes as having the lowest precedence (#17302) (Brad Zacher)
  • 9718a97 refactor: remove unnecessary code in flat-eslint.js (#17308) (Milos Djermanovic)
  • 1866e1d feat: allow flat config files to export a Promise (#17301) (Milos Djermanovic)
  • f82e56e perf: various performance improvements (#17135) (moonlightaria)
  • da81e66 chore: update eslint-plugin-jsdoc to 46.2.5 (#17245) (唯然)
  • 526e911 docs: resubmit pr 17115 doc changes (#17291) (唯然)
  • b991640 chore: switch eslint-config-eslint to the flat format (#17247) (唯然)
  • 391ed38 fix: Remove no-extra-semi autofix before potential directives (#17297) (Francesco Trotta)
  • e1314bf docs: Integration section and tutorial (#17132) (Ben Perlmutter)
  • 19a8c5d docs: Update README (GitHub Actions Bot)

v8.43.0 - June 16, 2023

  • 78350f6 chore: upgrade @​eslint/js@​8.43.0 (#17295) (Milos Djermanovic)
  • 8b855ea docs: resubmit pr17061 doc changes (#17292) (唯然)
  • 62bf759 chore: package.json update for @​eslint/js release (ESLint Jenkins)
  • 14581ff feat: directive prologue detection and autofix condition in quotes (#17284) (Francesco Trotta)
  • 372722e docs: resubmit pr17012 doc changes (#17293) (唯然)
  • 67e7af3 docs: resubmit custom-rules doc changes (#17294) (唯然)
  • 5338b56 fix: normalize cwd passed to ESLint/FlatESLint constructor (#17277) (Milos Djermanovic)
  • 9e3d77c docs: Resubmit Fix formatting in Custom Rules docs (#17281) (Milos Djermanovic)
  • 503647a docs: Resubmit markVariableAsUsed docs (#17280) (Nicholas C. Zakas)
  • 54383e6 fix: Remove no-extra-parens autofix for potential directives (#17022) (Francesco Trotta)
  • e0cf0d8 docs: Custom rule & plugin tutorial (#17024) (Ben Perlmutter)
  • 8e51ea9 docs: resubmit no-new rule documentation (#17264) (Nitin Kumar)
  • 1b217f8 docs: resubmit Custom Processors documentation (#17265) (Nitin Kumar)
  • 428fc76 docs: resubmit Create Plugins documentation (#17268) (Nitin Kumar)
  • bdca88c docs: resubmit Configuration Files documentation (#17267) (Nitin Kumar)
  • f5c01f2 docs: resubmit Manage Issues documentation (#17266) (Nitin Kumar)
  • b199295 docs: Resubmit custom rules update docs (#17273) (Ben Perlmutter)
  • e50fac3 feat: add declaration loc to message in block-scoped-var (#17252) (Milos Djermanovic)
  • 0e9980c docs: add new omitLastInOneLineClassBody option to the semi rule (#17263) (Nitin Kumar)
  • cb2560f docs: Resubmit getScope/getDeclaredVariables docs (#17262) (Nicholas C. Zakas)
  • 85d2b30 docs: explain how to include predefined globals (#17261) (Marcus Wyatt)
  • de4d3c1 docs: update flat config default ignore patterns (#17258) (Milos Djermanovic)
  • 3912f3a docs: Improve ignores documentation (#17239) (Francesco Trotta)

... (truncated)

Commits
  • 8c1ec65 8.44.0
  • 849933b Build: changelog update for 8.44.0
  • 49e46ed chore: upgrade @​eslint/js@​8.44.0 (#17329)
  • a1cb642 chore: package.json update for @​eslint/js release
  • 1766771 feat: add es2023 and es2024 environments (#17328)
  • 4c50400 feat: add ecmaVersion: 2024, regexp v flag parsing (#17324)
  • 4d411e4 feat: add ternaryOperandBinaryExpressions option to no-extra-parens rule (#17...
  • 840a264 test: More test cases for no-case-declarations (#17315)
  • e6e74f9 chore: package.json update for eslint-config-eslint release
  • eb3d794 chore: upgrade semver@7.5.3 (#17323)
  • Additional commits viewable in compare view

Updates eslint-plugin-eslint-plugin from 5.0.8 to 5.1.0

Release notes

Sourced from eslint-plugin-eslint-plugin's releases.

Release 5.1.0

5.1.0 (2023-05-18)

Features

Changelog

Sourced from eslint-plugin-eslint-plugin's changelog.

5.1.0 (2023-05-18)

Features

Commits
  • c4ddf68 chore: release v5.1.0
  • 6f6b1f4 feat: support eslint.config.js (#347)
  • a3d8898 build(deps-dev): Bump markdownlint-cli from 0.33.0 to 0.34.0 (#351)
  • 3fff008 chore: add tests for Node 20 (#349)
  • fd1c227 build(deps-dev): Bump eslint-plugin-unicorn from 45.0.2 to 46.0.0 (#343)
  • 983e0fe docs: split rules list into rule/test-related rules (#341)
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

Bumps the all-dependencies group with 7 updates:

| Package | Update |
| --- | --- |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | 5.59.2 to 5.61.0 |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | 5.59.2 to 5.61.0 |
| [aria-query](https://github.com/A11yance/aria-query) | 5.1.3 to 5.3.0 |
| [jsx-ast-utils](https://github.com/jsx-eslint/jsx-ast-utils) | 3.3.3 to 3.3.4 |
| [prettier](https://github.com/prettier/prettier) | 2.8.8 to 3.0.0 |
| [eslint](https://github.com/eslint/eslint) | 8.40.0 to 8.44.0 |
| [eslint-plugin-eslint-plugin](https://github.com/eslint-community/eslint-plugin-eslint-plugin) | 5.0.8 to 5.1.0 |


Updates `@typescript-eslint/eslint-plugin` from 5.59.2 to 5.61.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.61.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 5.59.2 to 5.61.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.61.0/packages/parser)

Updates `aria-query` from 5.1.3 to 5.3.0
- [Changelog](https://github.com/A11yance/aria-query/blob/main/CHANGELOG.md)
- [Commits](A11yance/aria-query@v5.1.3...v5.3.0)

Updates `jsx-ast-utils` from 3.3.3 to 3.3.4
- [Release notes](https://github.com/jsx-eslint/jsx-ast-utils/releases)
- [Changelog](https://github.com/jsx-eslint/jsx-ast-utils/blob/main/CHANGELOG.md)
- [Commits](jsx-eslint/jsx-ast-utils@v3.3.3...v3.3.4)

Updates `prettier` from 2.8.8 to 3.0.0
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.8...3.0.0)

Updates `eslint` from 8.40.0 to 8.44.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.40.0...v8.44.0)

Updates `eslint-plugin-eslint-plugin` from 5.0.8 to 5.1.0
- [Release notes](https://github.com/eslint-community/eslint-plugin-eslint-plugin/releases)
- [Changelog](https://github.com/eslint-community/eslint-plugin-eslint-plugin/blob/main/CHANGELOG.md)
- [Commits](eslint-community/eslint-plugin-eslint-plugin@v5.0.8...v5.1.0)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: aria-query
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: jsx-ast-utils
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: all-dependencies
- dependency-name: prettier
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: all-dependencies
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
- dependency-name: eslint-plugin-eslint-plugin
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: all-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner July 10, 2023 00:24
@dependabot dependabot bot requested a review from theinterned July 10, 2023 00:24
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 10, 2023
@khiga8
Copy link
Contributor

khiga8 commented Jul 10, 2023

FYI, there is now a new error from prettier:

TypeError: prettier.resolveConfig.sync is not a function
Occurred while linting /home/runner/work/eslint-plugin-github/eslint-plugin-github/.eslintrc.js:1
Rule: "prettier/prettier"

@khiga8
Copy link
Contributor

khiga8 commented Jul 10, 2023

Hi! I'm following up on the role-supports-aria-props tests reported breaking in bump PR workflow run!

It looks this is a result of elementRoles returned by aria-query undergoing some changes in A11yance/aria-query#447 followed by A11yance/aria-query#515.

For example, one of the keys in elementRoles which was previously

[{"attributes": [{"name": "href"}], "name": "a"}, ["link"]],

newly has a constraints set:

[{"attributes": [{"constraints": ["set"], "name": "href"}], "name": "a"}, ["link"]],

The code we have in role-supports-aria-props line 11-12 is

  delete key.constraints
  key.attributes = key.attributes?.filter(attribute => !('constraints' in attribute))

This ends up filtering out the above's entire attributes leaving:

[{"name": "a"}, ["link"]],

Therefore, <a> will end up being mapped to link. Similarly, <a href="#" aria-checked> for example, which has an href and should be mapped to link, can't find a matching role. This is resulting in a number of our tests breaking.

Next steps:

  • Determine if the constraints update on link is correct. What does "constraints": ["set"] mean?
  • If we determine the constraints update in aria-query is correct and we don't need to file a bug, then I think we would want to update the logic to not filter out the constraints that's set on the attribute key.

cc-ing @smockle who originally introduced this rule, do you have additional insights here?

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 11, 2023

Superseded by #452.

@dependabot dependabot bot closed this Jul 11, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/all-dependencies-bdd28ab418 branch July 11, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant