Skip to content

Update a11y rule config to not flag role being set for ul #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Update a11y rule config to not flag role being set for ul #608

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
570ca64
Don't flag ul with role='list'
khiga8 Feb 3, 2025
9e465e8
update comma
khiga8 Feb 3, 2025
e5b0378
Update lib/configs/react.js
khiga8 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/configs/react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ module.exports = {
nav: ['navigation'], // default in eslint-plugin-jsx-a11y
tbody: ['rowgroup'],
thead: ['rowgroup'],
ul: ['list'], // In webkit, setting list-style-type: none results in semantics being removed. Need explicit role.
},
],
},
Expand Down