-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update existing configs with missing package-ecosystems #140
Conversation
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
Signed-off-by: Zack Koppert <zkoppert@github.com>
@zkoppert still looking at this. Awesome addition 🎉 Could you please update the |
Great catch on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change. Couple suggestions but not blockers.
Signed-off-by: Zack Koppert <zkoppert@github.com>
Thank you for adding this feature. |
Great point @vidwah-nte, I've opened a new issue to track that request as currently it is not supported. #151 |
Pull Request
fixes #108
Proposed Changes
This pull request enhances the functionality of the Dependabot configuration file builder and environment variables handler in order to allow the action to recognize and add to existing dependabot configurations instead of skipping over those repos.
The changes include
build_dependabot_file
function to handle existing configurations,dependabot.yml
exists and has all needed package-ecosystems already in itdependabot.yml
exists and has 1 ecosystem in it and another ecosystem that should be addedReadiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducingReviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking