fix: ensure existing dependabot configs without end of file newlines get processed properly #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
fixes #231
Ensure existing dependabot configs without end of file newlines get processed properly so we can add new language configs without a formatting error. See #231 for details on formatting error.
Proposed Changes
This pull request introduces a new test case to the
test_dependabot_file.py
file to ensure thedependabot.yml
file is built correctly with bundler and specific configurations. It also modifies the existing config builder code to detect existing newlines and handle the case where one doesn't already exist. The goal of all of this is to prevent writing new language configs starting on the same line as the previous config, breaking the yaml format.Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducing@jeffrey-luszcz
Reviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking