Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bundler 2.3.11 to avoid deprecation warnings #3020

Closed

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Apr 15, 2022

This update enables us to suppress the following deprecation warning (from thor 1.1.0 bundled in Bundler 2.1.4):

Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Something that does not neatly fit into the binary options above

Something that does not neatly fit into the binary options above

  • My suggested edits maintain dependency around development process

Before this PR

Installing Bundler
  Using Bundler 2.1.4 from Gemfile.lock BUNDLED WITH 2.1.4
  /opt/hostedtoolcache/Ruby/3.1.0/x64/bin/gem install bundler -v 2.1.4
  Successfully installed bundler-2.1.4
  1 gem installed
  Took   0.51 seconds

https://github.com/github/explore/runs/6033102166?check_suite_focus=true

Refs.

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
@tnir tnir requested a review from a team as a code owner April 15, 2022 02:23
@MikeMcQuaid
Copy link
Contributor

Thanks for the PR but have now removed Gemfile.lock.

@tnir
Copy link
Contributor Author

tnir commented Apr 18, 2022

@MikeMcQuaid Thanks.

@tnir tnir deleted the tnir/rubocavoid-deprecation-warnings-from-thor branch April 18, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants