Remove custom emoji #158
Merged
Remove custom emoji #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GitHub.com, people predominantly use `:octocat:` and `:shipit:`, but other custom emoji not as much. These two most used custom emoji also happen to be specific to the GitHub brand, so it makes more sense that we add them as custom emoji in the app itself rather than shipping them with the gemoji library.
We no longer ship any images to extract.
muan
approved these changes
May 6, 2019
dgraham
approved these changes
May 6, 2019
captn3m0
added a commit
to endoflife-date/endoflife.date
that referenced
this pull request
Nov 24, 2022
-> 📝github/gemoji#158 removed custom emojis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the interest of shipping a simpler version of this library that supports only Unicode emoji out-of-the-box, this removes all custom emoji such as
:octocat:and:trollface:.Most of the custom emoji were kept for a long time for historical reasons, but nowadays see little use on GitHub. We're going to keep support for
:octocat:and:shipit:by moving them into our app, but we're going to say goodbye to others. 👋If you need to bring any of these back into your app, it's easy:
Simply keep
bowtie.pngthat's already present in your app, or get the old images from here https://github.com/github/gemoji/tree/4b2d44d272c2b3224e91d7ce873a9bda0946add3/imagesCloses #120, closes #128, fixes #149, closes #124