Extract domain parsing into testable function#18
Merged
Conversation
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Modify domains processing to a function for unit testing
Extract domain parsing into testable function
Oct 30, 2025
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The domain parsing logic was inlined in the CLI action handler, making it impossible to unit test independently. Tests had to duplicate the parsing logic rather than test the actual implementation.
Changes
parseDomains()function - Moved comma-split-trim-filter logic into an exported pure function with JSDocparseDomains()directly instead of duplicating logicprogram.parse()withrequire.main === moduleto prevent CLI execution on importExample
Before:
After:
Tests now directly verify the function:
Original prompt
Created from VS Code via the GitHub Pull Request extension.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.