Skip to content

fix: eliminate host binary dependency in setup-iptables for chroot mode #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mossaka merged 3 commits into from
Feb 4, 2026
+2 −1
Merged

fix: eliminate host binary dependency in setup-iptables for chroot mode #456

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e98d272
Initial plan
Copilot Jan 31, 2026
a060c00
fix: replace head with awk in setup-iptables for chroot mode
Copilot Jan 31, 2026
afc9998
Merge branch 'main' into copilot/debug-smoke-chroot-workflow
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion containers/agent/setup-iptables.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ SQUID_PORT="${SQUID_PROXY_PORT:-3128}"
echo "[iptables] Squid proxy: ${SQUID_HOST}:${SQUID_PORT}"

# Resolve Squid hostname to IP
SQUID_IP=$(getent hosts "$SQUID_HOST" | awk '{ print $1 }' | head -n 1)
# Use awk's NR to get first line to avoid host binary dependency in chroot mode
SQUID_IP=$(getent hosts "$SQUID_HOST" | awk 'NR==1 { print $1 }')
Copy link

Copilot AI Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The awk command should include an exit statement after printing the first line to match the behavior of head -n 1 and avoid unnecessarily processing remaining input. Change awk 'NR==1 { print $1 }' to awk 'NR==1 { print $1; exit }'. While this is a minor efficiency issue since getent hosts typically returns few lines, it's a best practice and makes the intent clearer.

Suggested change
SQUID_IP=$(getent hosts "$SQUID_HOST" | awk 'NR==1 { print $1 }')
SQUID_IP=$(getent hosts "$SQUID_HOST" | awk 'NR==1 { print $1; exit }')

Copilot uses AI. Check for mistakes.
if [ -z "$SQUID_IP" ]; then
echo "[iptables] ERROR: Could not resolve Squid proxy hostname: $SQUID_HOST"
exit 1
Expand Down
Loading