Skip to content

fix: remove leftover SQUID_INTERCEPT_PORT references #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mossaka merged 2 commits into from
Feb 6, 2026
Merged

fix: remove leftover SQUID_INTERCEPT_PORT references #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2236af
fix: ensure .copilot directory permissions before Copilot CLI install
Mossaka Feb 6, 2026
3b5cc8d
fix: remove leftover SQUID_INTERCEPT_PORT references from revert
Mossaka Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/smoke-chroot.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .github/workflows/smoke-chroot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,10 @@ steps:
if: always()
run: |
./scripts/ci/cleanup.sh || true
- name: Ensure .copilot directory permissions
run: |
mkdir -p /home/runner/.copilot
sudo chown -R runner:runner /home/runner/.copilot
Comment on lines +156 to +159
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states this PR removes leftover SQUID_INTERCEPT_PORT references, but this change adds new steps to ensure .copilot directory permissions before installing the GitHub Copilot CLI. This appears to be an unrelated bug fix for permission issues when running chroot tests with sudo. Either the PR description should be updated to mention this additional fix, or these changes should be in a separate PR.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@Mossaka Mossaka Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smoke-chroot.md and .lock.yml changes were auto-generated by the pre-commit hook which recompiles workflow lock files on commit. No manual changes were made to those files.

---

# Analyze Chroot Test Results
Expand Down
4 changes: 1 addition & 3 deletions src/docker-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { generateSquidConfig } from './squid-config';
import { generateSessionCa, initSslDb, CaFiles, parseUrlPatterns } from './ssl-bump';

const SQUID_PORT = 3128;
const SQUID_INTERCEPT_PORT = 3129; // Port for transparently intercepted traffic

/**
* Base image for the 'act' preset when building locally.
Expand Down Expand Up @@ -273,7 +272,7 @@ export function generateDockerCompose(
retries: 5,
start_period: '10s',
},
ports: [`${SQUID_PORT}:${SQUID_PORT}`, `${SQUID_INTERCEPT_PORT}:${SQUID_INTERCEPT_PORT}`],
ports: [`${SQUID_PORT}:${SQUID_PORT}`],
// Security hardening: Drop unnecessary capabilities
// Squid only needs network capabilities, not system administration capabilities
cap_drop: [
Expand Down Expand Up @@ -329,7 +328,6 @@ export function generateDockerCompose(
HTTPS_PROXY: `http://${networkConfig.squidIp}:${SQUID_PORT}`,
SQUID_PROXY_HOST: 'squid-proxy',
SQUID_PROXY_PORT: SQUID_PORT.toString(),
SQUID_INTERCEPT_PORT: SQUID_INTERCEPT_PORT.toString(),
HOME: homeDir,
PATH: '/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin',
};
Expand Down
Loading