Skip to content

fix: configure Java proxy via JAVA_TOOL_OPTIONS for Maven builds #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mossaka merged 8 commits into from
Feb 10, 2026
Merged

fix: configure Java proxy via JAVA_TOOL_OPTIONS for Maven builds #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6d936b6
Initial plan
Copilot Feb 9, 2026
e6919e7
fix(proxy): add Java proxy configuration via JAVA_TOOL_OPTIONS
Copilot Feb 9, 2026
5ec82d5
test: add tests for JAVA_TOOL_OPTIONS proxy configuration
Copilot Feb 9, 2026
d9a498d
fix: address code review feedback on JAVA_TOOL_OPTIONS
Copilot Feb 9, 2026
1975fb2
feat: add Java proxy configuration validation to build-test-java work…
Copilot Feb 9, 2026
adbe248
Merge remote-tracking branch 'origin/main' into copilot/fix-broken-pi…
Mossaka Feb 10, 2026
2c4ac89
fix: add Maven settings.xml proxy and fix nonProxyHosts
Mossaka Feb 10, 2026
775387f
fix: move Maven proxy config from docker-manager to workflow instruction
Mossaka Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/agentics-maintenance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# \ /\ / (_) | | | | ( | | | | (_) \ V V /\__ \
# \/ \/ \___/|_| |_|\_\|_| |_|\___/ \_/\_/ |___/
#
# This file was automatically generated by pkg/workflow/maintenance_workflow.go. DO NOT EDIT.
# This file was automatically generated by pkg/workflow/maintenance_workflow.go (v0.42.17). DO NOT EDIT.
#
# To regenerate this workflow, run:
# gh aw compile
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
pull-requests: write
steps:
- name: Setup Scripts
uses: github/gh-aw/actions/setup@v0.42.11-5-g59b2d5fe5
uses: github/gh-aw/actions/setup@v0.42.17
with:
destination: /opt/gh-aw/actions

Expand Down
33 changes: 7 additions & 26 deletions .github/workflows/build-test-java.lock.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 21 additions & 2 deletions .github/workflows/build-test-java.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,30 @@ Clone and test the following projects from the test repository:
1. **Clone Repository**: `gh repo clone Mossaka/gh-aw-firewall-test-java /tmp/test-java`
- **CRITICAL**: If clone fails, immediately call `safeoutputs-missing_tool` with message "CLONE_FAILED: Unable to clone test repository" and stop execution

2. **Test Projects**:
2. **Configure Maven Proxy**: Maven ignores Java system properties for proxy configuration, so you must create `~/.m2/settings.xml` before running any Maven commands:
```bash
mkdir -p ~/.m2
cat > ~/.m2/settings.xml << SETTINGS
<settings>
<proxies>
<proxy>
<id>awf-http</id><active>true</active><protocol>http</protocol>
<host>${SQUID_PROXY_HOST}</host><port>${SQUID_PROXY_PORT}</port>
</proxy>
<proxy>
<id>awf-https</id><active>true</active><protocol>https</protocol>
<host>${SQUID_PROXY_HOST}</host><port>${SQUID_PROXY_PORT}</port>
</proxy>
</proxies>
</settings>
SETTINGS
```

3. **Test Projects**:
- `gson`: `cd /tmp/test-java/gson && mvn compile && mvn test`
- `caffeine`: `cd /tmp/test-java/caffeine && mvn compile && mvn test`

3. **For each project**, capture:
4. **For each project**, capture:
- Compile success/failure
- Test pass/fail count
- Any error messages
Expand Down
5 changes: 3 additions & 2 deletions src/docker-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,9 @@ export function generateDockerCompose(
const userHome = getRealUserHome();
agentVolumes.push(`${userHome}:/host${userHome}:rw`);

// /tmp is needed for chroot mode to write temporary command scripts
// The entrypoint.sh writes to /host/tmp/awf-cmd-$$.sh
// /tmp is needed for chroot mode to write:
// - Temporary command scripts: /host/tmp/awf-cmd-$$.sh
// - One-shot token LD_PRELOAD library: /host/tmp/awf-lib/one-shot-token.so
agentVolumes.push('/tmp:/host/tmp:rw');

// Minimal /etc - only what's needed for runtime
Expand Down
Loading