-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add runtime configuration for one-shot token protection via AWF_ONE_SHOT_TOKENS #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b5afa49
Initial plan
Copilot d0de34f
feat: add runtime configuration for one-shot token list via AWF_ONE_S…
Copilot 351d394
fix: address code review feedback for one-shot token library
Copilot 13239bf
fix: resolve race condition and buffer underflow in token parsing
Copilot 132882c
refactor: optimize strlen usage and add MAX_TOKENS documentation
Copilot 7197e61
style: improve comment formatting for MAX_TOKENS
Copilot 2245791
fix: use strtok_r and fallback to defaults for empty token list
Copilot 439b53c
docs: update README with fallback behavior and strtok_r details
Copilot d50b467
refactor: explicitly reset num_tokens in fallback path for clarity
Copilot 0a8a050
docs: clarify defensive programming intent in num_tokens reset
Copilot e28fedd
Merge branch 'lpcox/one-shot-token-ld-preload' into copilot/sub-pr-604
lpcox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
strtok()inside an LD_PRELOAD interposer is risky becausestrtokmaintains internal state and can interfere with application code that is also usingstrtok(if getenv() is called between the app’s strtok() calls). Preferstrtok_r()(or manual parsing) to avoid clobbering global/tokenizer state.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit 2245791. Replaced
strtok()withstrtok_r()which uses a separate state pointer (saveptr) instead of global state. This prevents interference with application code that usesstrtok().Verified with test case that shows application's
strtok()calls work correctly even when interleaved withgetenv()calls that trigger the library's tokenization.