Skip to content

fix: use lowercase discussion categories to restore create_discussion tool#637

Merged
Mossaka merged 2 commits intomainfrom
fix/lowercase-discussion-categories
Feb 10, 2026
Merged

fix: use lowercase discussion categories to restore create_discussion tool#637
Mossaka merged 2 commits intomainfrom
fix/lowercase-discussion-categories

Conversation

@Mossaka
Copy link
Collaborator

@Mossaka Mossaka commented Feb 10, 2026

Summary

  • Discussion-creating workflows stopped posting since Feb 3 because gh-aw v0.40.0 added category validation (5f5f0e99) that silently rejects uppercase names
  • category: "General"parseDiscussionsConfig() returns nilcreate_discussion tool dropped from config.json/tools.json → agent falls back to noop
  • Fix: change "General" to "general" in all 3 affected workflow .md files and recompile
  • Also fixes bash:bash: true syntax in security-review.md

Affected workflows

  • ci-cd-gaps-assessment.md
  • security-review.md
  • pelis-agent-factory-advisor.md

Test plan

  • All 3 workflows compile with 0 errors, 0 warnings
  • Verified create_discussion is present in compiled config.json (was missing before)
  • Next scheduled run should create a discussion again

🤖 Generated with Claude Code

… tool

gh-aw v0.40.0 added category validation (commit 5f5f0e99) that silently
rejects uppercase category names, causing parseDiscussionsConfig() to
return nil. This dropped create_discussion from the compiled config.json
and tools.json, so agents had no discussion tool and fell back to noop.

Change "General" → "general" in all three discussion-creating workflows.
Also fix bash tool syntax in security-review.md (bash: → bash: true).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 10, 2026 08:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores discussion creation in agentic workflows by switching safe-outputs discussion category names to the lowercase slug expected by newer gh-aw validation, and recompiling the affected workflows/locks.

Changes:

  • Update safe-outputs.create-discussion.category from "General" to "general" in 3 workflow .md sources.
  • Fix security-review.md tool frontmatter (bash: true) and recompile the workflows into updated .lock.yml outputs.
  • Update locked gh-aw action reference metadata (including adding setup@v0.42.17 to the repo’s actions lock).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
.github/workflows/security-review.md Fixes tool frontmatter and switches discussion category to lowercase slug.
.github/workflows/security-review.lock.yml Recompiled lockfile; includes restored create_discussion safe-output tooling and various generated upgrades.
.github/workflows/pelis-agent-factory-advisor.md Switches discussion category to lowercase slug.
.github/workflows/pelis-agent-factory-advisor.lock.yml Recompiled lockfile reflecting the updated discussion category and generated workflow changes.
.github/workflows/ci-cd-gaps-assessment.md Switches discussion category to lowercase slug.
.github/workflows/ci-cd-gaps-assessment.lock.yml Recompiled lockfile reflecting the updated discussion category and generated workflow changes.
.github/aw/actions-lock.json Adds the github/gh-aw/actions/setup@v0.42.17 pin used by regenerated lockfiles.
.github/agents/agentic-workflows.agent.md Updates referenced gh-aw documentation links to v0.42.17 and tweaks guidance text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

sparse-checkout: |
.github
.agents
depth: 1
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout doesn’t have a depth input; this should be fetch-depth: 1 (as used in other workflows) or removed. As-is, the checkout depth setting will be ignored and may lead to unexpectedly slow or inconsistent checkouts.

Suggested change
depth: 1
fetch-depth: 1

Copilot uses AI. Check for mistakes.
Comment on lines 16 to 18
# This file was automatically generated by gh-aw (v0.42.17). DO NOT EDIT.
#
# To update this file, edit the corresponding .md file and run:
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lockfile change updates much more than the discussion category (e.g., bumps gh-aw to v0.42.17 and updates AWF/mcpg/copy/checkout behavior). If the intent of this PR is only to restore create_discussion, consider recompiling with the existing gh-aw version or explicitly calling out/isolating the broader upgrade so it can be reviewed as its own change.

Copilot uses AI. Check for mistakes.
Comment on lines 19 to 21
bash: true
web-fetch:
cache-memory: true
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash: true is the only workflow in the repo using a boolean here; other workflows/docs use a list of allowed patterns (e.g., bash: ["*"] or bash:\n - "*"). Consider switching to the consistent list form to avoid schema ambiguity and make the allowed surface explicit.

Copilot uses AI. Check for mistakes.
sparse-checkout: |
.github
.agents
depth: 1
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout doesn’t have a depth input; this should be fetch-depth: 1 (as used in other workflows) or removed. As-is, the checkout depth setting will be ignored and may lead to unexpectedly slow or inconsistent checkouts.

Suggested change
depth: 1
fetch-depth: 1

Copilot uses AI. Check for mistakes.
sparse-checkout: |
.github
.agents
depth: 1
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/checkout doesn’t have a depth input; this should be fetch-depth: 1 (as used in other workflows) or removed. As-is, the checkout depth setting will be ignored and may lead to unexpectedly slow or inconsistent checkouts.

Suggested change
depth: 1
fetch-depth: 1

Copilot uses AI. Check for mistakes.
…onflicts

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

🎬 THE ENDSmoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

@github-actions
Copy link
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 82.02% 82.02% ➡️ +0.00%
Statements 82.06% 82.06% ➡️ +0.00%
Functions 81.95% 81.95% ➡️ +0.00%
Branches 74.41% 74.41% ➡️ +0.00%

Coverage comparison generated by scripts/ci/compare-coverage.ts

@github-actions github-actions bot mentioned this pull request Feb 10, 2026
@github-actions
Copy link
Contributor

Node.js Build Test Results

Project Install Tests Status
clsx PASS ✅ PASS
execa PASS ✅ PASS
p-limit PASS ✅ PASS

Overall: ✅ PASS

All Node.js projects built and tested successfully.

AI generated by Build Test Node.js

@github-actions
Copy link
Contributor

Smoke Test Results

Last 2 Merged PRs:

Tests:

  • ✅ GitHub MCP: Retrieved merged PRs
  • ✅ Playwright: Page title verified ("GitHub")
  • ✅ File Writing: Created smoke-test-copilot-21882394032.txt
  • ✅ Bash Tool: Verified file contents

Status: PASS

cc @Mossaka

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

Smoke Test Results (Run #21882393992)

PRs reviewed:

✅ GitHub MCP - PASS
✅ Playwright - PASS (page title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
✅ File Writing - PASS
✅ Bash Tool - PASS

Status: PASS

AI generated by Smoke Claude

@github-actions
Copy link
Contributor

Go Build Test Results

Project Download Tests Status
color 1/1 PASS
env 1/1 PASS
uuid 1/1 PASS

Overall: PASS

All Go projects successfully downloaded dependencies and passed tests.

AI generated by Build Test Go

@github-actions
Copy link
Contributor

Deno Build Test Results

Project Tests Status
oak 1/1 ✅ PASS
std 1/1 ✅ PASS

Overall: ✅ PASS

All Deno tests completed successfully.

AI generated by Build Test Deno

@github-actions
Copy link
Contributor

C++ Build Test Results

Project CMake Build Status
fmt PASS
json PASS

Overall: PASS

All C++ projects built successfully.

AI generated by Build Test C++

@github-actions
Copy link
Contributor

.NET Build Test Results

Project Restore Build Run Status
hello-world PASS
json-parse PASS

Overall: PASS

All .NET projects built and ran successfully.

AI generated by Build Test .NET

@github-actions
Copy link
Contributor

PRs reviewed: chore(deps-dev): bump eslint from 8.57.1 to 10.0.0 in the linting group; feat: fail smoke workflows when safe outputs are not invoked
GitHub MCP review ✅
Safeinputs GH CLI ✅
Playwright title check ✅
Tavily search ❌ (no Tavily MCP tool)
File write ✅
Bash cat ✅
Discussion comment ✅
Build (npm ci && npm run build) ✅
Overall: FAIL

AI generated by Smoke Codex

@github-actions
Copy link
Contributor

Build Test: Java ✅

Java build tests completed successfully through AWF firewall.

Project Compile Tests Status
gson 1/1 PASS
caffeine 1/1 PASS

Overall: PASS

All Java projects compiled and tested successfully with Maven proxy configured for AWF.

AI generated by Build Test Java

@github-actions
Copy link
Contributor

Smoke Test Results

Last 2 Merged PRs:

Test Results:

  • ✅ GitHub MCP: Fetched merged PRs successfully
  • ✅ Playwright: Page title contains "GitHub"
  • ✅ File Write: Created test file successfully
  • ✅ Bash Tool: Verified file contents

Overall Status: PASS

cc @Mossaka

AI generated by Smoke Copilot

@github-actions
Copy link
Contributor

Smoke Test Results - Claude Engine

Recent PRs:

  • fix(workflows): correct discussion category case to enable posting
  • fix: restrict host gateway iptables bypass to allowed ports only

Test Results:

  • ✅ GitHub MCP
  • ✅ Playwright (title: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub")
  • ✅ File writing
  • ✅ Bash tool

Status: PASS

AI generated by Smoke Claude

@Mossaka Mossaka merged commit 3bd6df8 into main Feb 10, 2026
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant