fix: use lowercase discussion categories to restore create_discussion tool#637
fix: use lowercase discussion categories to restore create_discussion tool#637
Conversation
… tool gh-aw v0.40.0 added category validation (commit 5f5f0e99) that silently rejects uppercase category names, causing parseDiscussionsConfig() to return nil. This dropped create_discussion from the compiled config.json and tools.json, so agents had no discussion tool and fell back to noop. Change "General" → "general" in all three discussion-creating workflows. Also fix bash tool syntax in security-review.md (bash: → bash: true). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Restores discussion creation in agentic workflows by switching safe-outputs discussion category names to the lowercase slug expected by newer gh-aw validation, and recompiling the affected workflows/locks.
Changes:
- Update
safe-outputs.create-discussion.categoryfrom"General"to"general"in 3 workflow.mdsources. - Fix
security-review.mdtool frontmatter (bash: true) and recompile the workflows into updated.lock.ymloutputs. - Update locked
gh-awaction reference metadata (including addingsetup@v0.42.17to the repo’s actions lock).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/security-review.md | Fixes tool frontmatter and switches discussion category to lowercase slug. |
| .github/workflows/security-review.lock.yml | Recompiled lockfile; includes restored create_discussion safe-output tooling and various generated upgrades. |
| .github/workflows/pelis-agent-factory-advisor.md | Switches discussion category to lowercase slug. |
| .github/workflows/pelis-agent-factory-advisor.lock.yml | Recompiled lockfile reflecting the updated discussion category and generated workflow changes. |
| .github/workflows/ci-cd-gaps-assessment.md | Switches discussion category to lowercase slug. |
| .github/workflows/ci-cd-gaps-assessment.lock.yml | Recompiled lockfile reflecting the updated discussion category and generated workflow changes. |
| .github/aw/actions-lock.json | Adds the github/gh-aw/actions/setup@v0.42.17 pin used by regenerated lockfiles. |
| .github/agents/agentic-workflows.agent.md | Updates referenced gh-aw documentation links to v0.42.17 and tweaks guidance text. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sparse-checkout: | | ||
| .github | ||
| .agents | ||
| depth: 1 |
There was a problem hiding this comment.
actions/checkout doesn’t have a depth input; this should be fetch-depth: 1 (as used in other workflows) or removed. As-is, the checkout depth setting will be ignored and may lead to unexpectedly slow or inconsistent checkouts.
| depth: 1 | |
| fetch-depth: 1 |
| # This file was automatically generated by gh-aw (v0.42.17). DO NOT EDIT. | ||
| # | ||
| # To update this file, edit the corresponding .md file and run: |
There was a problem hiding this comment.
This lockfile change updates much more than the discussion category (e.g., bumps gh-aw to v0.42.17 and updates AWF/mcpg/copy/checkout behavior). If the intent of this PR is only to restore create_discussion, consider recompiling with the existing gh-aw version or explicitly calling out/isolating the broader upgrade so it can be reviewed as its own change.
| bash: true | ||
| web-fetch: | ||
| cache-memory: true |
There was a problem hiding this comment.
bash: true is the only workflow in the repo using a boolean here; other workflows/docs use a list of allowed patterns (e.g., bash: ["*"] or bash:\n - "*"). Consider switching to the consistent list form to avoid schema ambiguity and make the allowed surface explicit.
| sparse-checkout: | | ||
| .github | ||
| .agents | ||
| depth: 1 |
There was a problem hiding this comment.
actions/checkout doesn’t have a depth input; this should be fetch-depth: 1 (as used in other workflows) or removed. As-is, the checkout depth setting will be ignored and may lead to unexpectedly slow or inconsistent checkouts.
| depth: 1 | |
| fetch-depth: 1 |
| sparse-checkout: | | ||
| .github | ||
| .agents | ||
| depth: 1 |
There was a problem hiding this comment.
actions/checkout doesn’t have a depth input; this should be fetch-depth: 1 (as used in other workflows) or removed. As-is, the checkout depth setting will be ignored and may lead to unexpectedly slow or inconsistent checkouts.
| depth: 1 | |
| fetch-depth: 1 |
…onflicts Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
✅ Coverage Check PassedOverall Coverage
Coverage comparison generated by |
Node.js Build Test Results
Overall: ✅ PASS All Node.js projects built and tested successfully.
|
Smoke Test ResultsLast 2 Merged PRs:
Tests:
Status: PASS cc @Mossaka
|
|
Smoke Test Results (Run #21882393992) PRs reviewed:
✅ GitHub MCP - PASS Status: PASS
|
Go Build Test Results
Overall: PASS ✅ All Go projects successfully downloaded dependencies and passed tests.
|
Deno Build Test Results
Overall: ✅ PASS All Deno tests completed successfully.
|
C++ Build Test Results
Overall: PASS ✅ All C++ projects built successfully.
|
.NET Build Test Results
Overall: PASS ✅ All .NET projects built and ran successfully.
|
|
PRs reviewed: chore(deps-dev): bump eslint from 8.57.1 to 10.0.0 in the linting group; feat: fail smoke workflows when safe outputs are not invoked
|
Build Test: Java ✅Java build tests completed successfully through AWF firewall.
Overall: PASS All Java projects compiled and tested successfully with Maven proxy configured for AWF.
|
Smoke Test ResultsLast 2 Merged PRs:
Test Results:
Overall Status: PASS cc @Mossaka
|
Smoke Test Results - Claude EngineRecent PRs:
Test Results:
Status: PASS
|
Summary
5f5f0e99) that silently rejects uppercase namescategory: "General"→parseDiscussionsConfig()returnsnil→create_discussiontool dropped from config.json/tools.json → agent falls back tonoop"General"to"general"in all 3 affected workflow.mdfiles and recompilebash:→bash: truesyntax in security-review.mdAffected workflows
ci-cd-gaps-assessment.mdsecurity-review.mdpelis-agent-factory-advisor.mdTest plan
create_discussionis present in compiled config.json (was missing before)🤖 Generated with Claude Code