fix: ensure .copilot/logs exists before docker mount#643
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
|
📰 DEVELOPING STORY: Smoke Copilot reports failed. Our correspondents are investigating the incident... |
|
Chroot tests failed Smoke Chroot failed - See logs for details. |
|
@copilot can you please fix this error [agent 2/12] RUN apt-get update && apt-get install -y --no-install-recommends iptables curl ca-certificates git gh gnupg dnsutils net-tools netcat-openbsd gosu libcap2-bin && export PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" && if ! command -v node >/dev/null 2>&1 || ! node --version | grep -qE '^v22.'; then apt-get remove -y nodejs npm || true && curl -fsSL https://deb.nodesource.com/setup_22.x | bash - && apt-get install -y nodejs && node --version | grep -q "^v22." || (echo "ERROR: Node.js 22 not installed correctly" && exit 1) && npx --version || (echo "ERROR: npx not found" && exit 1); fi && rm -rf /var/lib/apt/lists/*:
|
Fixed in commit a65e546. Changes made:
These changes make the build resilient to:
The binary distribution approach is more reliable as it doesn't depend on apt repositories or third-party setup scripts. |
ee782e6
into
copilot/fix-github-actions-workflow-again
There was a problem hiding this comment.
Pull request overview
Updates the Docker Compose generation logic to prevent Docker bind-mount failures by ensuring the host-side ~/.copilot/logs directory exists before mounting ~/.copilot read-only and overlaying logs with a separate read-write mount.
Changes:
- Create
~/.copilot/logson the host (recursively) before adding Docker volume mounts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Ensure .copilot/logs directory exists on host before mounting | ||
| // This is critical: Docker needs the mount point to exist before it can overlay | ||
| // the read-write mount on top of the read-only parent mount | ||
| const copilotLogsDir = path.join(copilotConfigDir, 'logs'); |
There was a problem hiding this comment.
The PR description checklist mentions apt-get retry logic, Node.js install changes, xz-utils, and CA certificate updates, but this PR diff only changes host log directory creation for the .copilot/logs mount. Please update the PR description to match the actual change set (or include the missing changes in this PR).
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.