-
Notifications
You must be signed in to change notification settings - Fork 13
Closed
2 / 22 of 2 issues completed
Copy link
Description
Summary
Analysis of internal/server/ Go files found 2 significant duplication patterns in the HTTP server creation code. Both affect routed.go and transport.go.
Detected Patterns
This analysis found 2 significant duplication patterns:
applyAuthIfConfiguredhelper not used in routed.go - Severity: Medium - See sub-issue [duplicate-code] Duplicate Code Pattern: applyAuthIfConfigured helper not reused in routed.go #1160- Common HTTP mux route registration duplicated - Severity: Medium - See sub-issue [duplicate-code] Duplicate Code Pattern: Common HTTP mux setup duplicated between routed.go and transport.go #1159
Overall Impact
- Total Duplicated Lines: ~20 lines of duplicated logic
- Affected Files: 2 files (
internal/server/routed.go,internal/server/transport.go) - Maintainability Risk: Medium — changes to auth or shared endpoint behavior require updates in two places
- Refactoring Priority: Low-Medium — straightforward consolidation with minimal risk
Next Steps
- Review individual pattern sub-issues for detailed analysis
- Prioritize refactoring based on severity and impact
- Create implementation plan for highest priority patterns
Analysis Metadata
- Analyzed Files: 3 Go files (
routed.go,transport.go,unified.go) - Detection Method: Pattern search and semantic analysis
- Commit: 4cd522d
- Analysis Date: 2026-02-20
Reactions are currently unavailable