Skip to content

Fix: Validate tool name presence in MCP tools/call requests #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Jan 16, 2026
Merged

Fix: Validate tool name presence in MCP tools/call requests #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c658329
Initial plan
Copilot Jan 16, 2026
b6901f5
Add validation for missing tool name in sys.go
Copilot Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions internal/sys/sys.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ func (s *SysServer) HandleRequest(method string, params json.RawMessage) (interf
log.Printf("Failed to unmarshal tool call params: %v", err)
return nil, fmt.Errorf("invalid params: %w", err)
}
if callParams.Name == "" {
log.Printf("Tool call missing name field")
return nil, fmt.Errorf("invalid params: missing tool name")
}
log.Printf("Calling tool: name=%s", callParams.Name)
return s.callTool(callParams.Name, callParams.Arguments)
default:
Expand Down
4 changes: 0 additions & 4 deletions internal/sys/sys_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,6 @@ func TestHandleRequest_ToolsCall_UnknownTool(t *testing.T) {
name: "unknown tool",
toolName: "unknown_tool",
},
{
name: "empty tool name",
toolName: "",
},
{
name: "misspelled tool",
toolName: "sys_initialize",
Expand Down
Loading