Fix duplicate test function declarations in logger package#445
Merged
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Run linting tests and fix any problems found
Fix duplicate test function declarations in logger package
Jan 23, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logger package had duplicate test function declarations across
rpc_logger_test.goandrpc_helpers_test.go, causing compilation failures. Go doesn't allow duplicate function names in the same package, even across test files.Changes
Removed duplicate tests from
rpc_logger_test.go:TestTruncateAndSanitizeTestExtractEssentialFieldsThese functions test
rpc_helpers.goand are properly tested inrpc_helpers_test.go.Fixed test assertions in
rpc_helpers_test.go:"token: "→"token="after normalization)Applied gofmt to fix trailing whitespace in
validation_schema.goandrpc_helpers_test.goWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
this-host-does-not-exist-12345.com/tmp/go-build3826922757/b282/mcp.test /tmp/go-build3826922757/b282/mcp.test -test.testlogfile=/tmp/go-build3826922757/b282/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true submodules | head -n 10 -trimpath x_amd64/vet -p mime/quotedprintls-files -lang=go1.25 x_amd64/vet -uns�� anitize common_test.go x_amd64/vet go1.25.6 -c=4 -nolocalimports x_amd64/vet(dns block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.