Merged
Conversation
Collaborator
lpcox
commented
Feb 3, 2026
lpcox
commented
- Rename 'log' to 'logTypes' in internal/mcp/types.go to avoid conflict with standard log package import in connection.go
- Fix SA1012 staticcheck warning in slog_adapter_test.go by replacing nil context with context.TODO()
- Rename 'log' to 'logTypes' in internal/mcp/types.go to avoid conflict with standard log package import in connection.go - Fix SA1012 staticcheck warning in slog_adapter_test.go by replacing nil context with context.TODO()
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes build errors and lint warnings by addressing a variable naming conflict and a staticcheck warning.
Changes:
- Renamed the logger variable from
logtologTypesininternal/mcp/types.goto avoid conflict with the standard librarylogpackage imported inconnection.go - Fixed SA1012 staticcheck warning by replacing
nilcontext withcontext.TODO()in a test case
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/mcp/types.go | Renamed logger variable from log to logTypes throughout the file (13 occurrences) to avoid import naming conflict |
| internal/logger/slog_adapter_test.go | Replaced nil context with context.TODO() in test to satisfy staticcheck SA1012 warning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.