Fix nightly-mcp-stress-test: Move mcp-servers to top-level field#628
Merged
Fix nightly-mcp-stress-test: Move mcp-servers to top-level field#628
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nightly MCP stress test for server loading
Fix nightly-mcp-stress-test: Move mcp-servers to top-level field
Feb 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the nightly MCP stress test workflow so that the MCP Gateway correctly discovers all configured MCP servers, and updates the accompanying documentation to match the spec.
Changes:
- Move the
mcp-serversconfiguration block from undersandbox.mcpto a top-levelmcp-serverskey alongsidetoolsin the workflow YAML. - Keep
sandbox.mcpfocused solely on configuring the gateway container image. - Update the agentics documentation to describe the new
mcp-serversplacement and clarify the relationship betweensandbox.mcp(gateway container) andmcp-servers(server configuration).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/nightly-mcp-stress-test.md |
Moves the 20 MCP server definitions to a top-level mcp-servers section so the MCP Gateway can load them per the spec, leaving sandbox.mcp to configure only the gateway container. |
.github/agentics/nightly-mcp-stress-test.md |
Updates prose to reference the top-level mcp-servers configuration and clarifies that the gateway container is provided by sandbox.mcp while servers come from mcp-servers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow incorrectly nested
mcp-serversundersandbox.mcp, preventing the MCP gateway from loading the 20 configured servers.Before:
After:
Per the spec,
mcp-serversis a top-level field alongsidetoolsandnetwork. Thesandbox.mcpblock is only for gateway container configuration.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.