Add GOOGLE_APPLICATION_CREDENTIALS to gdrive MCP server#659
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR adds Google OAuth credentials configuration to the gdrive MCP server to fix authentication failures detected by the nightly stress test. The changes enable the gdrive MCP server to authenticate with Google Drive API.
Changes:
- Added
GOOGLE_APPLICATION_CREDENTIALSenvironment variable to gdrive MCP server configuration in both the workflow definition (.md) and compiled lock file (.yml) - Updated Docker command to pass the credentials environment variable to containers
- Added secret redaction for
GOOGLE_APPLICATION_CREDENTIALSto prevent credential exposure in logs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/nightly-mcp-stress-test.md | Added env configuration with GOOGLE_APPLICATION_CREDENTIALS to gdrive MCP server definition |
| .github/workflows/nightly-mcp-stress-test.lock.yml | Compiled changes including env variable in step environment, Docker command, JSON config, and secret redaction setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ] | ||
| ], | ||
| "env": { | ||
| "GOOGLE_APPLICATION_CREDENTIALS": "${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }}" |
There was a problem hiding this comment.
The JSON configuration uses GitHub Actions template syntax directly (${{ secrets.GOOGLE_APPLICATION_CREDENTIALS }}), which is inconsistent with how other environment variables are referenced in this heredoc.
For consistency with the existing pattern (e.g., line 466 which uses \${GITHUB_MCP_SERVER_TOKEN}), this should use the escaped bash variable syntax \${GOOGLE_APPLICATION_CREDENTIALS} instead. The secret is already made available as an environment variable on line 384, so it can be referenced using bash variable expansion.
This approach is more consistent with how the codebase handles environment variables in heredocs and makes the code more maintainable.
Nightly stress test detected gdrive MCP server failing on missing OAuth credentials.
Changes
env.GOOGLE_APPLICATION_CREDENTIALSto gdrive MCP server config innightly-mcp-stress-test.mdPost-merge
Repository maintainers need to add
GOOGLE_APPLICATION_CREDENTIALSto repository secrets with Google OAuth credentials JSON.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.