Skip to content

Conversation

@lpcox
Copy link
Collaborator

@lpcox lpcox commented Feb 6, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 6, 2026 21:10
@lpcox lpcox merged commit 6b2b196 into main Feb 6, 2026
3 checks passed
@lpcox lpcox deleted the lpcox/update-serena-go branch February 6, 2026 21:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Serena MCP server container build to use a newer Go toolchain and gopls version for Go language support inside the image.

Changes:

  • Bump gopls builder stage base image from golang:1.24-alpine to golang:1.25-alpine.
  • Update pinned gopls version from v0.17.1 to v0.21.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +5 to +7
FROM golang:1.25-alpine AS gopls-builder
# Pin to gopls v0.21.0 which is compatible with Go 1.25
RUN go install golang.org/x/tools/gopls@v0.21.0
Copy link

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The builder stage is pinned to Go 1.25, but the final image installs golang-go from Debian without pinning a matching Go toolchain version. Since gopls shells out to the go toolchain for analysis/build operations, a mismatch here can cause unexpected behavior when analyzing modules with go 1.25.0 (see go.mod). Consider ensuring the final image provides the same Go version (e.g., copy /usr/local/go from a Go 1.25 stage or install a version-pinned Go toolchain), rather than relying on the distro package version.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant