[Code Quality] Complete migration from deprecated ApplyActionPinToStep to typed alternative

[github-actions]

Description

Complete the migration from deprecated ApplyActionPinToStep() to the type-safe ApplyActionPinToTypedStep() alternative. The deprecated function is marked for removal and uses map[string]any with type assertions, while the typed alternative provides compile-time safety.

Current State

The codebase has deprecated functions still in use:

• ApplyActionPinToStep() at pkg/workflow/action_pins.go:306
• ApplyActionPinsToSteps() at pkg/workflow/action_pins.go:402-412

Both functions are marked deprecated but still have active call sites that need migration.

Suggested Changes

1. Identify all call sites using deprecated functions
2. Migrate to typed alternatives:
   • ApplyActionPinToStep() → ApplyActionPinToTypedStep()
   • ApplyActionPinsToSteps() → ApplyActionPinsToTypedSteps()
3. Remove deprecated functions after migration is complete
4. Update tests to use typed alternatives

Files Affected

• Primary: pkg/workflow/action_pins.go (lines 306-412)
• Call sites: Search codebase for usages with grep -r "ApplyActionPinToStep" pkg/

Success Criteria

• ✅ Zero usages of deprecated ApplyActionPinToStep() function
• ✅ Zero usages of deprecated ApplyActionPinsToSteps() function
• ✅ Deprecated functions removed from codebase
• ✅ All existing tests pass with typed alternatives
• ✅ No new type assertion failures introduced

Benefits

• Compile-time safety: Eliminates runtime type assertion failures
• Code clarity: Typed function signatures are self-documenting
• Reduced technical debt: Removes deprecated code path
• Maintainability: Easier refactoring with strong types

Source

Extracted from Typist Analysis discussion #12238 - "Priority 1: Critical - Complete Typed Step Migration" section.

The discussion notes: "Code already exists with better types, function is marked deprecated, migration path is clear, will reduce type assertion failures."

Priority

High - Quick win (2-3 days effort), eliminates deprecated code, improves type safety

AI generated by Discussion Task Miner - Code Quality Improvement Agent

• expires on Feb 11, 2026, 1:22 PM UTC

[github-actions]

🍪 Issue Monster has assigned this to Copilot!

I've identified this issue as a good candidate for automated resolution and assigned it to the Copilot agent.

The Copilot agent will analyze the issue and create a pull request with the fix.

Om nom nom! 🍪

AI generated by Issue Monster